Deprecate verbose features #423
Merged
+60
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelSkayn
force-pushed
the
deprecate-features
branch
from
859296f to
a6f7f1b
Compare
DelSkayn
force-pushed
the
deprecate-features
branch
from
e162d29 to
ee52430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The features
allocator,properties,classesandarray-bufferwere initially created because their functionality required patches to QuickJS. These patches have been removed and now these features don't have much use outside of cutting out some code from compilation.Therefore we should deprecate these features an just provide their functionality by default.