Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config docs in-line with example config #102

Merged
merged 8 commits into from
Jul 18, 2023

Conversation

apalrd
Copy link
Contributor

@apalrd apalrd commented Jun 26, 2023

There are still too many undocumented options in the code, but this at least brings the docs to match the example config and descriptions listed there.

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for nebula-docs-dn ready!

Name Link
🔨 Latest commit 0f50522
🔍 Latest deploy log https://app.netlify.com/sites/nebula-docs-dn/deploys/64b5973ebfa5270008773950
😎 Deploy Preview https://deploy-preview-102--nebula-docs-dn.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IanVS IanVS requested a review from johnmaguire July 3, 2023 13:16
docs/config/tun.mdx Outdated Show resolved Hide resolved
docs/config/tun.mdx Outdated Show resolved Hide resolved
docs/config/punchy.mdx Outdated Show resolved Hide resolved
docs/config/listen.mdx Show resolved Hide resolved
Copy link
Collaborator

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@johnmaguire johnmaguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for all your effort on this!

I don't have permission to push to your branch, so I'll post a couple tweaks as a followup PR.

@johnmaguire johnmaguire merged commit 2605cdf into DefinedNet:main Jul 18, 2023
johnmaguire added a commit that referenced this pull request Jul 19, 2023
@apalrd submitted an excellent PR adding documentation around many
previously undocumented options in #102. This PR makes a few nitpick
changes to things like the meta descriptions, grammar, and adds a couple
clarifying notes.

---------

Co-authored-by: Caleb Jasik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants