Feat: Prefetch Function Support in Adapter #3027
Merged
+77
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The rainbow-wallet.ts adapter exports: |
|
The rainbow-wallet.ts adapter exports: |
|
The rainbow-wallet.ts adapter exports: |
g1nt0ki
reviewed
Apr 26, 2025
g1nt0ki
reviewed
Apr 26, 2025
adapters/utils/runAdapter.ts
Outdated
| @@ -17,6 +17,7 @@ function getUnixTimeNow() { | |||
| export default async function runAdapter(volumeAdapter: BaseAdapter, cleanCurrentDayTimestamp: number, chainBlocks: ChainBlocks, id?: string, version?: string, { | |||
| adapterVersion = 1, | |||
| isTest = false, | |||
| prefetch = null, | |||
There was a problem hiding this comment.
volumeAdapter will have the prefetch field right? if you use that instead of the extra field here, prefetch will work without automatically for all the code calling runAdapter without any modification to them
|
The rainbow-wallet.ts adapter exports: |
g1nt0ki
approved these changes
Apr 26, 2025
|
The rainbow-wallet.ts adapter exports: |
|
The rainbow-wallet.ts adapter exports: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prefetch function solves a key inefficiency in multi-chain DeFi adapters by fetching common data once instead of repeatedly for each chain. In the Rainbow Wallet example, it executes a single Dune SQL query that retrieves fee data for all chains, then stores this in preFetchedResults. Each chain's fetch function accesses this shared data through options.preFetchedResults, eliminating redundant database queries, reducing API load, and improving performance. This approach keeps the codebase cleaner by separating shared data fetching from chain-specific processing while maintaining backward compatibility.
This function would improve performance and use less resource/credits. mostly would be useful in dune/allium query/APIs where we can have multi-chain data in single request.