Skip to content

orbiter finnce #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

orbiter finnce #2704

wants to merge 1 commit into from

Conversation

dtmkeng
Copy link
Contributor

@dtmkeng dtmkeng commented Mar 26, 2025

@llamabutler
Copy link

The orbiter-finance.ts adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees orbiter-finance.ts

🦙 Running ORBITER-FINANCE.TS adapter 🦙
---------------------------------------------------
Start Date:	Tue, 25 Mar 2025 06:05:45 GMT
End Date:	Wed, 26 Mar 2025 06:05:45 GMT
---------------------------------------------------

ETHEREUM 👇
Backfill start time: 6/12/2024
Daily fees: 7
End timestamp: 1742969144 (2025-03-26T06:05:44.000Z)


OPTIMISM 👇
Backfill start time: 6/12/2024
Daily fees: 0
End timestamp: 1742969144 (2025-03-26T06:05:44.000Z)


BASE 👇
Backfill start time: 6/12/2024
Daily fees: 0
End timestamp: 1742969144 (2025-03-26T06:05:44.000Z)


ARBITRUM 👇
Backfill start time: 6/12/2024
Daily fees: 0
End timestamp: 1742969144 (2025-03-26T06:05:44.000Z)


POLYGON 👇
Backfill start time: 6/12/2024
Daily fees: 0
End timestamp: 1742969144 (2025-03-26T06:05:44.000Z)


BSC 👇
Backfill start time: 6/12/2024
Daily fees: 0
End timestamp: 1742969144 (2025-03-26T06:05:44.000Z)


BLAST 👇
Backfill start time: 6/12/2024
Daily fees: 0
End timestamp: 1742969144 (2025-03-26T06:05:44.000Z)


---- AGGREGATE 👇
Backfill start time not defined
End timestamp: 1742969144 (2025-03-26T06:05:44.000Z)
Daily fees: 7

Copy link
Member

@g1nt0ki g1nt0ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is either incomplete or incorrect? maybe each token has it's own poolContract?

check the contract on different chains, on polygon, the contract doesnt exists, on other chains, it has only a handful of events

@dtmkeng
Copy link
Contributor Author

dtmkeng commented Apr 17, 2025

@g1nt0ki Yes, it’s incorrect. I’ve already checked with their team, and they confirmed that the correct way to calculate fees is by tracking the balance change from the source to the destination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants