Add support to AWS Prowler V3 json format #8028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiencarol
previously requested changes
May 2, 2023
Co-authored-by: Damien Carol <[email protected]>
Maffooch
requested changes
May 3, 2023
github-actions
bot
added
the
settings_changes
|
@Maffooch can you validate deduplication settings ? |
Maffooch
requested changes
May 4, 2023
Co-authored-by: Cody Maffucci <[email protected]>
Maffooch
approved these changes
May 5, 2023
Maffooch
requested changes
May 9, 2023
|
@anderson-slompo are you able to revert commits of merging master into your branch? There is a lot of extra changes in this PR now that should not be there |
github-actions
bot
added
docker
New Migration
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
removed
docs
helm
New Migration
Maffooch
previously approved these changes
May 11, 2023
Maffooch
dismissed
their stale review
I was a little hasty here.. See the error in the unit tests
Maffooch
approved these changes
May 15, 2023
devGregA
approved these changes
May 16, 2023
cneill
approved these changes
May 16, 2023
|
@damiencarol Are you good with this? |
|
@damiencarol Are you OK with this? |
Closed
|
Thanks a lot guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to import aws prowler v3 json scan file referent to this issue