Skip to content

🐛 add user mention notifications in note creation for Engagement, Finding, and Tests #13696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

🐛 add user mention notifications in note creation for Engagement, Finding, and Tests #13696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions dojo/api_v2/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from django.db.models.query import QuerySet as DjangoQuerySet
from django.http import FileResponse, HttpResponse
from django.shortcuts import get_object_or_404
from django.urls import reverse
from django.utils import timezone
from django_filters.rest_framework import DjangoFilterBackend
from drf_spectacular.renderers import OpenApiJsonRenderer2
Expand Down Expand Up @@ -176,6 +177,7 @@
generate_file_response,
get_setting,
get_system_setting,
process_tag_notifications,
)

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -528,6 +530,15 @@ def notes(self, request, pk=None):
)
note.save()
engagement.notes.add(note)
# Determine if we need to send any notifications for user mentioned
process_tag_notifications(
request=request,
note=note,
parent_url=request.build_absolute_uri(
reverse("view_engagement", args=(engagement.id,)),
),
parent_title=f"Engagement: {engagement.name}",
)

serialized_note = serializers.NoteSerializer(
{"author": author, "entry": entry, "private": private},
Expand Down Expand Up @@ -1086,6 +1097,15 @@ def notes(self, request, pk=None):
)
note.save()
finding.notes.add(note)
# Determine if we need to send any notifications for user mentioned
process_tag_notifications(
request=request,
note=note,
parent_url=request.build_absolute_uri(
reverse("view_finding", args=(finding.id,)),
),
parent_title=f"Finding: {finding.title}",
)

if finding.has_jira_issue:
jira_helper.add_comment(finding, note)
Expand Down Expand Up @@ -2135,6 +2155,15 @@ def notes(self, request, pk=None):
)
note.save()
test.notes.add(note)
# Determine if we need to send any notifications for user mentioned
process_tag_notifications(
request=request,
note=note,
parent_url=request.build_absolute_uri(
reverse("view_test", args=(test.id,)),
),
parent_title=f"Test: {test.title}",
)

serialized_note = serializers.NoteSerializer(
{"author": author, "entry": entry, "private": private},
Expand Down