Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render SAML attributes_map_dir config value to string instead of an object #11764

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

catshapednoodles
Copy link

Description

Fixes #11763

Test results

My workspace is not properly setup to run Python tests unfortunately

Checklist

This checklist is for your information.

  • Make sure to rebase your PR against the very latest dev.
  • Features/Changes should be submitted against the dev.
  • Bugfixes should be submitted against the bugfix branch.
  • Give a meaningful name to your PR, as it may end up being used in the release notes.
  • Your code is flake8 compliant.
  • Your code is python 3.11 compliant.
  • If this is a new feature and not a bug fix, you've included the proper documentation in the docs at https://github.com/DefectDojo/django-DefectDojo/tree/dev/docs as part of this PR.
  • Model changes must include the necessary migrations in the dojo/db_migrations folder.
  • Add applicable tests to the unit tests.
  • Add the proper label to categorize your PR.

@github-actions github-actions bot added the settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR label Feb 7, 2025
Copy link

dryrunsecurity bot commented Feb 7, 2025

DryRun Security Summary

The PR safely modifies the SAML2 configuration by converting a Path object to a string for the attribute map directory.

Expand for full summary

PR updates the SAML2 configuration in settings.dist.py by converting a Path object to a string for attribute map directory. No security vulnerabilities were found in this change.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

@catshapednoodles catshapednoodles changed the title Render SAML attributes dir config value to string instead of an object Render SAML attributes_map_dir config value to string instead of an object Feb 7, 2025
@Maffooch Maffooch merged commit 597778f into DefectDojo:bugfix Feb 7, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants