Duplicate Delete Errors: Inline import history + tags (B) #11740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
This may need more work to prevent duplicate history records: Waiting for decision on option A, B, C before spending more time on it. |
|
Closed, see #11739 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes and see: #6217
This PR replaces the bulk creation of the import history at the end of the (re)import with inline statements to create these records one by one. This prevents
IntegrityErrorsfrom happening during race conditions with the background duplicate delete job.Test results
Manual testing only as creating a unit test / integration test is not feasible within a reasonable timeframe.