Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff: Add PLC18 and fix PLC1802 #11707

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Feb 1, 2025

Add PLC18* rules and fix len-test (PLC1802)

Copy link

dryrunsecurity bot commented Feb 1, 2025

DryRun Security Summary

The pull request enhances both the Ruff linter configuration by adding the PLC18 rule and improves DefectDojo's SLA management through asynchronous updating capabilities.

Expand for full summary

Summary:

The changes in this pull request are focused on improving the configuration and functionality of the Ruff linter and the SLA (Service Level Agreement) management within the DefectDojo application.

The Ruff linter configuration changes involve updating the select list to include the PLC18 rule, which will now be checked and reported on by the linter. This change does not have any direct security implications, but it suggests that the project is taking code quality and security into consideration as part of its linting process.

The changes to the DefectDojo application focus on improving the performance and reliability of the SLA configuration management. This includes introducing asynchronous updating of the SLA configuration and findings, as well as ensuring that the SLA configuration can be updated without causing issues with the findings that are currently associated with it. These changes help to maintain the integrity of the application's data and ensure that the SLA information remains accurate and up-to-date.

Files Changed:

  1. ruff.toml: This file contains the configuration for the Ruff linter. The changes include the addition of the PLC18 rule to the select list, which will now be checked and reported on by the linter.

  2. dojo/models.py: This file contains the models for the DefectDojo application. The changes include the addition of async_updating fields to the SLA_Configuration and Product models, as well as updates to the save() methods of these models to handle the asynchronous updating of the SLA configuration and findings.

Code Analysis

We ran 9 analyzers against 2 files and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant