feat(db-checker): Extension of "db reachable" #11651
Open
+47
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiblik
force-pushed
the
db_checker
branch
2 times, most recently
from
ac089d0 to
1cf37e0
Compare
Maffooch
approved these changes
Jan 29, 2025
cneill
reviewed
Feb 3, 2025
| @@ -85,6 +85,7 @@ jobs: | |||
| ./helm/defectdojo \ | |||
| --set django.ingress.enabled=true \ | |||
| --set imagePullPolicy=Never \ | |||
| --set initializer.keepSeconds="x" \ | |||
There was a problem hiding this comment.
Is this value intentional? Docs suggest this ttlSecondsAfterFinished should be an integer - I'm not sure what it would do with a value of "x"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen #10497
Extend
wait_for_database_to_be_reachable. Not only for simple operation but check that DB is compatible.Added based on #10490
This PR also contains changes from #11650 because they are needed for proper testing of this functionality.