-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added accessibility for the pagination snippet #11591
Added accessibility for the pagination snippet #11591
Conversation
DryRun Security SummaryThe pull request enhances the accessibility of the pagination functionality by adding ARIA attributes, semantic markup, and improved labeling for screen readers in the Expand for full summarySummary: The code changes in this pull request are focused on improving the accessibility of the pagination functionality in the web application. The changes include adding ARIA attributes to provide more context and labeling for screen readers, as well as using semantic markup to better communicate the purpose of non-interactive elements. These accessibility enhancements do not introduce any significant security risks and are a positive change that benefits users, including those with disabilities. Files Changed:
Code AnalysisWe ran
Overall Riskiness🔴 Risk threshold exceeded. We've notified @mtesauro, @grendel513. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small adjustment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Fixes #11590
The respective nav section is recognised under the aria-label "Pagination navigation".
The current page has assigned value
aria-disabled true
withtabindex -1
for better navigation. Instead of "1", "2", "3"... screen reader says "Page 1" / "Page 2" etc... When using page size dropdown button, user will hear "xyz items per page" instead of just a number.<li>
elements are assigned presentation role and their nested<a>
elements are assigned to menuitem role for more intuitive orientation with keyboard.