Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm-psql): Drop pinning of old version of postgresql #10507

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Jul 3, 2024

Fix #10490

Copy link

dryrunsecurity bot commented Jul 3, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Server-Side Request Forgery Analyzer 0 findings
IDOR Analyzer 0 findings
SQL Injection Analyzer 0 findings
Authn/Authz Analyzer 0 findings
Configured Codepaths Analyzer 0 findings
Secrets Analyzer 0 findings
Sensitive Files Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The provided code changes are related to the Helm chart configuration for the DefectDojo application, specifically the values.yaml file. The key changes include the removal of the image.tag property for the PostgreSQL database, indicating that the PostgreSQL version is now managed automatically or through a different configuration mechanism. Additionally, the patch removes the createMysqlSecret and createPostgresqlSecret flags, suggesting that the application is now using a different approach to manage database credentials, likely through the use of existing secrets or other external configuration sources.

From an application security perspective, the changes are positive and focus on improving the security and maintainability of the DefectDojo deployment. The application is now using PostgreSQL as the primary database, which generally has better security features and performance characteristics compared to MySQL. The removal of the secret creation flags indicates that the application is now relying on external secret management, a recommended security practice. The patch also includes configurations for enabling network policies, which can help restrict the network access to and from the DefectDojo pods, and proper Ingress configuration, ensuring secure external access to the application. Additionally, the security context configurations for the Django and Nginx containers, setting the runAsUser property to 1001, is a good practice to avoid running the containers as the root user, which can help mitigate potential privilege escalation vulnerabilities.

Files Changed:

  • helm/defectdojo/values.yaml: This file contains the Helm chart configuration for the DefectDojo application. The key changes include:
    • Removal of the image.tag property for the PostgreSQL database, indicating that the PostgreSQL version is now managed automatically or through a different configuration mechanism.
    • Removal of the createMysqlSecret and createPostgresqlSecret flags, suggesting that the application is now using a different approach to manage database credentials, likely through the use of existing secrets or other external configuration sources.
    • Configuration for enabling network policies, which can help restrict the network access to and from the DefectDojo pods.
    • Ingress configuration, including enabling TLS and specifying the Ingress class, to ensure secure external access to the application.
    • Security context configurations for the Django and Nginx containers, setting the runAsUser property to 1001, to avoid running the containers as the root user.

Powered by DryRun Security

@github-actions github-actions bot added the helm label Jul 3, 2024
@kiblik kiblik closed this Jul 3, 2024
@kiblik kiblik reopened this Jul 3, 2024
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit 9446f08 into DefectDojo:bugfix Jul 8, 2024
238 of 239 checks passed
@kiblik kiblik deleted the helm_drop_pin_psql branch July 8, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants