Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff: Address migrations, reduce redundancy, and remove Flake8 #10492

Closed
wants to merge 4 commits into from

Conversation

Maffooch
Copy link
Contributor

@Maffooch Maffooch commented Jul 2, 2024

Addresses the following:

  • Update our ruff.toml to rename TRIO to ASYNC (per their migration blog post)
  • Update the renovate config to ignore the the requirements-lint.txt file to prevent duplicate PRs from renovate and dependabot
  • Remove flake8 GHAs as we are now using ruff, and then simplify the ruff lint GHA

Copy link

dryrunsecurity bot commented Jul 2, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Server-Side Request Forgery Analyzer 0 findings
Configured Codepaths Analyzer 0 findings
IDOR Analyzer 0 findings
Sensitive Files Analyzer 0 findings
SQL Injection Analyzer 0 findings
Authn/Authz Analyzer 0 findings
Secrets Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The changes in this pull request are primarily focused on updating the configuration for various tools used in the project, such as the Renovate bot, the Ruff linter, and the GitHub Actions workflow for running the Ruff linter. These changes do not directly introduce any security vulnerabilities, but it's important to review them to ensure that security-related checks and configurations are not inadvertently modified or removed.

The key changes include:

  1. Updating the Renovate bot configuration to ignore the requirements-lint.txt file, which is a reasonable change as this file likely contains metadata related to linting the project's Python dependencies.
  2. Removing the "TRIO" rule from the Ruff linter configuration, which may be intentional, but it's important to ensure that security-related rules are not inadvertently disabled.
  3. Modifying the GitHub Actions workflow to handle different event types, such as pull requests, and running the Ruff linter on the codebase, which is a good practice for maintaining code quality and consistency.

Overall, these changes appear to be routine maintenance updates to the project's tooling and configuration, and they do not raise any immediate security concerns. However, it's important to carefully review any changes to security-related configurations or linter rules to ensure that the application's security posture is not compromised.

Files Changed:

  1. .github/renovate.json: This file contains the configuration for the Renovate bot, which has been updated to ignore the requirements-lint.txt file.
  2. ruff.toml: This is the configuration file for the Ruff linter, and the changes involve the removal of the "TRIO" rule from the select list.
  3. .github/workflows/ruff.yml: This is the GitHub Actions workflow for running the Ruff linter, and the changes include modifications to the checkout behavior and the linting process.

Powered by DryRun Security

@Maffooch Maffooch changed the base branch from dev to bugfix July 2, 2024 18:26
@Maffooch Maffooch changed the base branch from bugfix to dev July 2, 2024 18:27
@Maffooch Maffooch closed this Jul 2, 2024
@Maffooch Maffooch deleted the ruff branch July 16, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant