Nounly Sample #336
Open
Nounly Sample #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit111
had a problem deploying
to
deploy-changed-samples
GitHub Actions
Failure
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| a.setAttribute("data-etag", r.etag); | ||
| a.setAttribute("data-date", r.date); | ||
| a.title = r.origUrl || r.url; | ||
| a.href = r.url; |
Check warning
Code scanning / CodeQL
Client-side URL redirect Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 1 day ago
To fix the problem, we need to ensure that the URL used for redirection is validated against a list of authorized URLs. This can be done by maintaining a list of allowed URLs and checking if the user-provided URL matches any entry in this list before performing the redirection.
- Create a list of authorized URLs.
- Validate the user-provided URL against this list.
- Only perform the redirection if the URL is authorized.
Suggested changeset
1
samples/nounly/public/javascripts/app.js
| @@ -1,2 +1,10 @@ | ||
| (function () { | ||
| const authorizedUrls = [ | ||
| "https://example.com", | ||
| "https://another-example.com" | ||
| ]; | ||
|
|
||
| function isAuthorizedUrl(url) { | ||
| return authorizedUrls.some(authorizedUrl => url.startsWith(authorizedUrl)); | ||
| } | ||
| function E(id) { return document.getElementById(id); } | ||
| @@ -86,3 +94,7 @@ | ||
| a.title = r.origUrl || r.url; | ||
| a.href = r.url; | ||
| if (isAuthorizedUrl(r.url)) { | ||
| a.href = r.url; | ||
| } else { | ||
| a.href = "#"; | ||
| } | ||
| a.appendChild(document.createTextNode(r.code)); |
Copilot is powered by AI and may make mistakes. Always verify output.
commit111
temporarily deployed
to
deploy-changed-samples
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124
Nounly is a URL shortener website built with Go, JavaScript, and Redis, and can be deployed with Defang as a sample.
See the real Noun.ly website for reference.
Samples Checklist
✅ All good!