feat(opnsense): enable PID file monitoring for Defguard Gateway service #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this is useful to anyone but these are the changes I needed to make to allow OPNsense to properly manage the gateway service. YMMV. |
Replace nocheck flag with proper PID file configuration to enable OPNsense service status monitoring. The service now correctly tracks the gateway process state via PID file. Changes: - Remove 'nocheck' flag from service definition - Add dynamic PID file path reading from user configuration - Set default PID file location to /var/run/defguard_gateway.pid - Add default value to PidFile model field for consistency - Update form to display default PID file location hint - Simplify config.toml template to always output pidfile with default The PID file location can now be customized by users through the UI, or will default to /var/run/defguard_gateway.pid. This ensures OPNsense can properly monitor and report the gateway service status.
jamtur01
force-pushed
the
opnsense_pidfile
branch
from
b57a094 to
22099e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace nocheck flag with proper PID file configuration to enable OPNsense service status monitoring. The service now correctly tracks the gateway process state via PID file.
Changes:
/var/run/defguard_gateway.pidactions_defguardgateway.conftoactions_defguard_gateway.confwhich now causes opnsense to correctly run the right action. Prior to this configd.py would returnaction defguardgateway.status not found for user rootThe PID file location can now be customized by users through the UI, or will default to
/var/run/defguard_gateway.pid. This ensures OPNsense can properly monitor and report the gateway service status.