Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a bug in fusedAdamW which will crash when amsgrad==false and refer to uninitialized variables #1356

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix a bug in fusedAdamW which will crash when amsgrad==false and refer to uninitialized variables #1356

merged 1 commit into from
Nov 14, 2024

Conversation

Wrench-Git
Copy link
Collaborator

@Wrench-Git Wrench-Git commented Nov 1, 2024 •
edited
Loading

Motivation and Context

Description

Use cases (Optional)

BC-breaking (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the Contributors.md to create this PR.
  • Pre-commit or linting tools indicated in Contributors.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@Wrench-Git Wrench-Git requested a review from yangbofun as a code owner November 1, 2024 07:25
@Wrench-Git Wrench-Git force-pushed the fix_fused_adamw_false_amsgrad_bug branch from 016efeb to 89a594b Compare November 1, 2024 07:29
@yangbofun yangbofun merged commit 6747443 into DeepLink-org:main Nov 14, 2024
18 checks passed
@yangbofun yangbofun deleted the fix_fused_adamw_false_amsgrad_bug branch November 14, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangbofun yangbofun yangbofun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wrench-Git @yangbofun