Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XML charge command #813

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Conversation

flubshi
Copy link
Contributor

@flubshi flubshi commented Feb 9, 2025

Implement new XML charge command: <ctl><charge type='go'/></ctl>

Runtime tested - works :)

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (fc74a93) to head (cf9f072).
Report is 1 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #813      +/-   ##
==========================================
+ Coverage   91.52%   91.58%   +0.06%     
==========================================
  Files         113      114       +1     
  Lines        4352     4360       +8     
  Branches      292      292              
==========================================
+ Hits         3983     3993      +10     
+ Misses        300      299       -1     
+ Partials       69       68       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 9, 2025

CodSpeed Performance Report

Merging #813 will not alter performance

Comparing flubshi:xml_charge_command (cf9f072) with dev (fc74a93)

Summary

✅ 6 untouched benchmarks

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @flubshi 👍

@edenhaus edenhaus added the pr: new-feature PR, which adds a new feature label Feb 9, 2025
@edenhaus edenhaus merged commit 86fbe07 into DeebotUniverse:dev Feb 9, 2025
27 checks passed
@flubshi flubshi deleted the xml_charge_command branch February 9, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new-feature PR, which adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants