Skip to content

Fix location when reporting errors in another file #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 24, 2025
Merged

Fix location when reporting errors in another file #1310

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8cdf44
use location of require command instead of error in imported module
Alidra Oct 8, 2025
f206a0e
refine code to work in case error is in the same file
Alidra Oct 8, 2025
9294fc8
remove all OK diagnostics
Alidra Oct 10, 2025
bcddf9b
.Revert "remove all OK diagnostics"
Alidra Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/lsp/lp_doc.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,19 @@ let process_cmd _file (nodes,st,dg,logs) ast =

| Cmd_Error(loc, msg) ->
let nodes = { ast; exec = false; goals = [] } :: nodes in
let loc = option_default loc Command.(get_pos ast) in
nodes, st, (loc, 1, msg, None) :: dg, ((1, msg), loc) :: logs
let cmd_loc, loc = match cmd_loc, loc with
| Some l, Some Some l' ->
if l.fname = l'.fname then
(* if error in the same file, use the precise location *)
Some l', Some l'
else
(* else, use the location of the command *)
cmd_loc, Some l'
(* Otherwise,
cmd_loc doesn't change and loc is : option_default loc cmd_loc *)
| _, Some l' -> cmd_loc, l'
| _, None -> cmd_loc, cmd_loc in
nodes, st, (cmd_loc, 1, msg, None) :: dg, ((1, msg), loc) :: logs

let new_doc ~uri ~version ~text =
let root, logs =
Expand Down
Loading