Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Flatpak compatibility #146

Merged
merged 3 commits into from
Dec 21, 2024
Merged

Conversation

Keyaku
Copy link
Contributor

@Keyaku Keyaku commented Dec 20, 2024

Overall changes:

  • Making subprocess calls from within flatpak sandbox use flatpak-spawn --host for commands like git or chmod.
  • Avoided resetting git branch if script finds it's not in main (I don't want to lose all that work again lol).
  • chmoding with executable flag only the appropriate files. This command might not even be necessary at all.
  • Fixed random crash on exit.

Keyaku and others added 3 commits December 18, 2024 22:37
Changes:
- Gitignoring .vscode.
- Added function to detect if in flatpak.
- Prepended flatpak commands in case script is running in flatpak.
- Small git branch protection; avoids reseting all the hard work just because it's in a different branch.
- Doing a chmod -R on select files (NOTE: chmodding might not even be necessary).
- Improved check_flatpak() logic (can be improved further).
- Fixed undefined `reps` variable under `fromflat` condition.
@marvin1099 marvin1099 merged commit 4eea04c into DeckCheatz:main Dec 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants