Skip to content

Implements SslStreamProxy write synchronization with SemaphoreSlim #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JAZDaddy wants to merge 1 commit into
base: WriteAsyncCollision
Choose a base branch
from
Open

Implements SslStreamProxy write synchronization with SemaphoreSlim #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNICommon.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,21 +104,33 @@ internal enum SNISMUXFlags

internal class SslStreamProxy : SslStream
{
private Task _currentTask;
private readonly SemaphoreSlim _semaphore;

public SslStreamProxy(Stream innerStream, bool leaveInnerStreamOpen, RemoteCertificateValidationCallback userCertificateValidationCallback)
public SslStreamProxy(Stream innerStream, bool leaveInnerStreamOpen, RemoteCertificateValidationCallback userCertificateValidationCallback)
: base(innerStream, leaveInnerStreamOpen, userCertificateValidationCallback)
{ }
{
_semaphore = new SemaphoreSlim(1); /* granting one concurrent write on innerStream */
}

// Prevent the WriteAsync's collision
public override Task WriteAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken)
public override async Task WriteAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken)
{
if (_currentTask != null && _currentTask.Status != TaskStatus.RanToCompletion)
await _semaphore.WaitAsync(cancellationToken);
try
{
_currentTask.Wait(cancellationToken);
await base.WriteAsync(buffer, offset, count, cancellationToken);
}
_currentTask = base.WriteAsync(buffer, offset, count, cancellationToken);
return _currentTask;
finally
{
_semaphore.Release();
}
return;
}

protected override void Dispose(bool disposing)
{
_semaphore?.Dispose();
base.Dispose(disposing);
}
}

Expand Down