Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format git log to include only commit shas #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JacobNinja
Copy link

I am running into an issue during import where a commit message would contain the "^M" control character. This will cause codeq to error on a StringIndexOutOfBoundsException.

Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: 40
    at java.lang.String.substring(String.java:1907)
    at clojure.core$subs.invoke(core.clj:4517)
    at datomic.codeq.core$commits$fn__69$fn__70.invoke(core.clj:428)
    at clojure.core$mapv$fn__6258.invoke(core.clj:6241)

Formatting the git log "pretty" option to return only commit shas will eliminate the need to parse commit messages in bulk, and reduce destructuring in the argument list of some functions.

@originalhat
Copy link

Bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants