Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_integration_aws_external_id] Add new resource to generate an AWS Integration external ID #2880

Merged
merged 15 commits into from
Mar 6, 2025

Conversation

raymondeah
Copy link
Contributor

@raymondeah raymondeah commented Mar 3, 2025

Adds a new resource datadog_integration_aws_external_id that can be used to generate a new external ID using api/v2/integration/aws/generate_new_external_id.

This resource has some special behavior that is documented as warnings in the .md as well as in the plan:
apply: A new external ID must be used to create an AWS account integration within 48 hours of creation or it will expire.
destroy: Running terraform destroy only removes the resource from Terraform state and does not deactivate anything in Datadog or AWS.

https://datadoghq.atlassian.net/browse/AWSCORE-132

@raymondeah raymondeah marked this pull request as ready for review March 3, 2025 21:23
@raymondeah raymondeah requested review from a team as code owners March 3, 2025 21:23
michaelcretzman
michaelcretzman previously approved these changes Mar 4, 2025
ktmq
ktmq previously approved these changes Mar 5, 2025
Copy link
Contributor

@ktmq ktmq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!! 🙌

@raymondeah raymondeah dismissed stale reviews from ktmq and michaelcretzman via 0ae831f March 5, 2025 20:50
@raymondeah
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 6, 2025

View all feedbacks in Devflow UI.
2025-03-06 18:25:53 UTC ℹ️ Start processing command /merge


2025-03-06 18:25:57 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 3m.


2025-03-06 18:47:19 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 2fb52c2 into master Mar 6, 2025
17 checks passed
@dd-mergequeue dd-mergequeue bot deleted the ray.eah/awscore-132-resource-external-id branch March 6, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants