Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a class to declare several scenarios #3757

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Allow a class to declare several scenarios #3757

merged 2 commits into from
Dec 31, 2024

Conversation

cbeauchesne
Copy link
Collaborator

Motivation

Preparation for #3377

Changes

Several @scenarios decorator can be use for a class

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@cbeauchesne cbeauchesne changed the title Allow a class to declare several scenario Allow a class to declare several scenarios Dec 31, 2024
robertomonteromiguel
robertomonteromiguel reviewed Dec 31, 2024
View reviewed changes
utils/_context/_scenarios/endtoend.py Outdated
def is_part_of(self, declared_scenario):
return declared_scenario in (self.name, "EndToEndScenario")
def is_part_of(self, declared_scenarios: list[str]) -> bool:
return self.name in declared_scenarios or "EndToEndScenario" in declared_scenarios
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this. Why the "or" clause?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It for this particular use case : https://github.com/DataDog/system-tests/blob/main/tests/test_schemas.py#L10

Which will be removed soon by #3754 ...

@cbeauchesne cbeauchesne marked this pull request as ready for review December 31, 2024 12:45
@cbeauchesne cbeauchesne requested a review from a team as a code owner December 31, 2024 12:45
@cbeauchesne cbeauchesne merged commit db9fbb5 into main Dec 31, 2024
431 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/allow-several-scenarios branch December 31, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertomonteromiguel robertomonteromiguel robertomonteromiguel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbeauchesne @robertomonteromiguel