Skip to content

build: bump protobuf and ring as suggested by dependabot#938

Merged
ivoanjo merged 7 commits intomainfrom
ivoanjo/bump-dependencies
Mar 21, 2025
Merged

build: bump protobuf and ring as suggested by dependabot#938
ivoanjo merged 7 commits intomainfrom
ivoanjo/bump-dependencies

Conversation

@ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Mar 18, 2025

What does this PR do?

Dependabot was suggesting bumping these two, and they seem to work fine.

Motivation

Keep our dependencies up-to-date.

Additional Notes

N/A

How to test the change?

Our existing test coverage should be enough to cover these.

@ivoanjo ivoanjo requested a review from a team as a code owner March 18, 2025 09:55
@ivoanjo ivoanjo requested a review from a team as a code owner March 18, 2025 09:57
paullegranddc
paullegranddc reviewed Mar 18, 2025
View reviewed changes
Cargo.lock Outdated
Comment on lines +6416 to +6409
"windows-sys 0.59.0",
"windows-sys 0.48.0",
Copy link
Contributor

@paullegranddc paullegranddc Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why the dependency is actually getting downgraded?

Copy link
Member Author

@ivoanjo ivoanjo Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch... Cargo seems to be non-deterministic here, or at least buggy -- running cargo update -p winapi-util will make it flip back and forth on versions here. Fixed manually in 72bef35 .

@pr-commenter
Copy link

pr-commenter bot commented Mar 18, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-03-21 09:36:18

Comparing candidate commit 405a237 in PR branch ivoanjo/bump-dependencies with baseline commit 51d4c2b in branch main.

Found 9 performance improvements and 2 performance regressions! Performance is the same for 41 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/ 3782-8224-6310-005

  • 🟩 execution_time [-4.694µs; -4.556µs] or [-5.716%; -5.547%]
  • 🟩 throughput [+715629.732op/s; +738112.512op/s] or [+5.877%; +6.062%]

scenario:credit_card/is_card_number/ 378282246310005

  • 🟩 execution_time [-5.543µs; -5.426µs] or [-7.218%; -7.066%]
  • 🟩 throughput [+990808.027op/s; +1012560.858op/s] or [+7.609%; +7.776%]

scenario:credit_card/is_card_number/378282246310005

  • 🟥 execution_time [+4.634µs; +4.762µs] or [+6.408%; +6.585%]
  • 🟥 throughput [-855167.119op/s; -832321.236op/s] or [-6.183%; -6.018%]

scenario:credit_card/is_card_number/x371413321323331

  • 🟩 execution_time [-414.314ns; -408.145ns] or [-6.425%; -6.329%]
  • 🟩 throughput [+10487500.629op/s; +10635769.187op/s] or [+6.763%; +6.858%]

scenario:credit_card/is_card_number_no_luhn/x371413321323331

  • 🟩 execution_time [-410.848ns; -406.077ns] or [-6.374%; -6.300%]
  • 🟩 throughput [+10436960.869op/s; +10555900.959op/s] or [+6.727%; +6.804%]

scenario:sql/obfuscate_sql_string

  • 🟩 execution_time [-5.729µs; -5.566µs] or [-7.778%; -7.555%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 405a237 1742549079 ivoanjo/bump-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.317µs 2.364µs ± 0.013µs 2.364µs ± 0.005µs 2.370µs 2.393µs 2.399µs 2.403µs 1.64% -0.139 2.511 0.56% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.362µs; 2.366µs] or [-0.077%; +0.077%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 405a237 1742549079 ivoanjo/bump-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 55.132ms 55.793ms ± 0.283ms 55.886ms ± 0.179ms 56.014ms 56.133ms 56.414ms 56.557ms 1.20% -0.192 -0.874 0.51% 0.020ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [55.753ms; 55.832ms] or [-0.070%; +0.070%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 405a237 1742549079 ivoanjo/bump-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.185µs 3.203µs ± 1.513µs 2.999µs ± 0.026µs 3.023µs 3.657µs 14.008µs 16.538µs 451.40% 7.536 57.933 47.11% 0.107µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.993µs; 3.413µs] or [-6.546%; +6.546%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 405a237 1742549079 ivoanjo/bump-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.525µs 209.076µs ± 0.281µs 209.054µs ± 0.137µs 209.189µs 209.371µs 209.583µs 211.419µs 1.13% 4.156 30.246 0.13% 0.020µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4729939.505op/s 4782964.529op/s ± 6390.284op/s 4783450.219op/s ± 3130.443op/s 4786596.572op/s 4790472.581op/s 4792183.074op/s 4795595.725op/s 0.25% -4.096 29.639 0.13% 451.861op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.236µs 18.308µs ± 0.042µs 18.313µs ± 0.027µs 18.334µs 18.371µs 18.405µs 18.516µs 1.11% 0.432 1.868 0.23% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54007737.176op/s 54619939.928op/s ± 126526.959op/s 54606944.726op/s ± 79406.367op/s 54712071.406op/s 54827270.488op/s 54836089.675op/s 54837294.521op/s 0.42% -0.407 1.764 0.23% 8946.807op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.655µs 10.722µs ± 0.040µs 10.720µs ± 0.020µs 10.741µs 10.766µs 10.803µs 11.107µs 3.61% 4.479 41.419 0.37% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 90032127.618op/s 93263491.175op/s ± 341687.927op/s 93286594.358op/s ± 177531.267op/s 93460161.186op/s 93715307.762op/s 93847178.980op/s 93851838.269op/s 0.61% -4.226 38.311 0.37% 24160.985op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.037µs; 209.115µs] or [-0.019%; +0.019%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4782078.897op/s; 4783850.161op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.303µs; 18.314µs] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54602404.508op/s; 54637475.348op/s] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.717µs; 10.728µs] or [-0.052%; +0.052%] None None None
normalization/normalize_name/normalize_name/good throughput [93216136.515op/s; 93310845.836op/s] or [-0.051%; +0.051%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 405a237 1742549079 ivoanjo/bump-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.022µs 5.090µs ± 0.036µs 5.095µs ± 0.023µs 5.115µs 5.151µs 5.154µs 5.159µs 1.27% -0.056 -1.027 0.71% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.085µs; 5.095µs] or [-0.099%; +0.099%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 405a237 1742549079 ivoanjo/bump-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.677µs 25.392µs ± 11.000µs 18.041µs ± 0.155µs 34.181µs 42.757µs 54.141µs 101.170µs 460.78% 2.413 11.243 43.21% 0.778µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.868µs; 26.917µs] or [-6.004%; +6.004%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 405a237 1742549079 ivoanjo/bump-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 67.820µs 68.017µs ± 0.302µs 67.982µs ± 0.046µs 68.024µs 68.131µs 68.585µs 71.986µs 5.89% 11.513 147.274 0.44% 0.021µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [67.975µs; 68.059µs] or [-0.062%; +0.062%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 405a237 1742549079 ivoanjo/bump-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 504.119µs 505.393µs ± 0.678µs 505.407µs ± 0.349µs 505.709µs 506.116µs 506.458µs 512.187µs 1.34% 4.908 48.500 0.13% 0.048µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1952413.183op/s 1978662.554op/s ± 2638.511op/s 1978604.470op/s ± 1365.530op/s 1980168.993op/s 1981944.639op/s 1983432.610op/s 1983659.276op/s 0.26% -4.803 47.167 0.13% 186.571op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 460.871µs 461.724µs ± 0.843µs 461.627µs ± 0.194µs 461.813µs 462.288µs 462.692µs 469.766µs 1.76% 7.846 69.836 0.18% 0.060µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2128720.597op/s 2165800.893op/s ± 3898.686op/s 2166249.256op/s ± 911.852op/s 2167171.257op/s 2168330.473op/s 2169442.914op/s 2169806.300op/s 0.16% -7.790 69.143 0.18% 275.679op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 174.254µs 176.182µs ± 0.440µs 176.248µs ± 0.262µs 176.492µs 176.720µs 176.870µs 176.922µs 0.38% -1.349 2.788 0.25% 0.031µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5652214.551op/s 5675975.481op/s ± 14215.342op/s 5673832.671op/s ± 8423.939op/s 5683264.603op/s 5702111.885op/s 5726962.752op/s 5738746.772op/s 1.14% 1.372 2.880 0.25% 1005.177op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.519µs 37.660µs ± 0.045µs 37.659µs ± 0.029µs 37.686µs 37.734µs 37.779µs 37.876µs 0.58% 0.646 2.402 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26401890.498op/s 26553593.640op/s ± 31426.049op/s 26554114.274op/s ± 20323.463op/s 26574729.434op/s 26597242.298op/s 26615883.231op/s 26652827.857op/s 0.37% -0.632 2.356 0.12% 2222.157op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.197µs 48.316µs ± 0.114µs 48.305µs ± 0.029µs 48.337µs 48.395µs 48.478µs 49.756µs 3.00% 10.286 127.778 0.23% 0.008µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20097917.970op/s 20697183.882op/s ± 47515.872op/s 20701766.355op/s ± 12591.826op/s 20713395.224op/s 20731358.021op/s 20744704.728op/s 20748375.025op/s 0.23% -10.117 124.918 0.23% 3359.880op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.299µs; 505.487µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1978296.881op/s; 1979028.226op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [461.608µs; 461.841µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2165260.573op/s; 2166341.213op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.121µs; 176.243µs] or [-0.035%; +0.035%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5674005.372op/s; 5677945.591op/s] or [-0.035%; +0.035%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.654µs; 37.666µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26549238.291op/s; 26557948.988op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.300µs; 48.332µs] or [-0.033%; +0.033%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20690598.640op/s; 20703769.125op/s] or [-0.032%; +0.032%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 405a237 1742549079 ivoanjo/bump-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.027µs 33.927µs ± 1.130µs 33.237µs ± 0.092µs 35.580µs 35.688µs 36.035µs 36.433µs 9.62% 0.915 -1.098 3.32% 0.080µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.771µs; 34.084µs] or [-0.461%; +0.461%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 405a237 1742549079 ivoanjo/bump-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.896µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.913µs 3.916µs 3.918µs 3.920µs 0.20% -0.791 3.523 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255104484.092op/s 255643514.255op/s ± 190079.250op/s 255620297.615op/s ± 106623.308op/s 255756138.485op/s 255951093.146op/s 256027754.456op/s 256682606.687op/s 0.42% 0.802 3.576 0.07% 13440.633op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.677µs 77.506µs ± 0.444µs 77.410µs ± 0.268µs 77.767µs 78.257µs 78.765µs 79.262µs 2.39% 0.816 0.726 0.57% 0.031µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12616340.508op/s 12902660.812op/s ± 73631.232op/s 12918168.775op/s ± 44573.163op/s 12953206.006op/s 13002318.696op/s 13023331.865op/s 13041799.574op/s 0.96% -0.781 0.624 0.57% 5206.514op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.688µs 71.311µs ± 0.327µs 71.229µs ± 0.202µs 71.519µs 71.907µs 72.291µs 72.339µs 1.56% 0.798 0.317 0.46% 0.023µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13823719.149op/s 14023419.413op/s ± 64167.760op/s 14039218.621op/s ± 40002.564op/s 14067736.043op/s 14106002.669op/s 14133546.112op/s 14146597.477op/s 0.76% -0.775 0.267 0.46% 4537.346op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.896µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.913µs 3.916µs 3.917µs 3.920µs 0.20% -0.839 3.242 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255098045.143op/s 255642440.213op/s ± 187685.013op/s 255608236.643op/s ± 118045.158op/s 255759719.898op/s 255931488.754op/s 256020389.358op/s 256661634.145op/s 0.41% 0.849 3.292 0.07% 13271.335op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 76.359µs 77.001µs ± 0.342µs 76.947µs ± 0.215µs 77.219µs 77.577µs 77.965µs 78.766µs 2.36% 1.151 3.169 0.44% 0.024µs 1 200
credit_card/is_card_number/378282246310005 throughput 12695808.430op/s 12987067.832op/s ± 57361.021op/s 12995992.048op/s ± 36231.358op/s 13024078.925op/s 13067789.687op/s 13083710.245op/s 13095968.567op/s 0.77% -1.101 2.920 0.44% 4056.037op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.745µs 51.831µs ± 0.034µs 51.830µs ± 0.019µs 51.850µs 51.889µs 51.904µs 51.932µs 0.20% 0.076 0.102 0.07% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19256038.464op/s 19293566.994op/s ± 12776.069op/s 19294000.531op/s ± 7086.121op/s 19300419.786op/s 19315308.928op/s 19321620.952op/s 19325565.791op/s 0.16% -0.072 0.101 0.07% 903.405op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.027µs 6.037µs ± 0.006µs 6.037µs ± 0.002µs 6.039µs 6.045µs 6.051µs 6.091µs 0.91% 3.944 32.876 0.10% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 164170131.380op/s 165639705.362op/s ± 162251.829op/s 165656159.100op/s ± 66079.654op/s 165717031.577op/s 165849621.236op/s 165890446.712op/s 165910756.434op/s 0.15% -3.887 32.208 0.10% 11472.937op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.894µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.914µs 3.918µs 3.920µs 3.923µs 0.26% -0.612 4.324 0.09% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254932449.381op/s 255589044.256op/s ± 218142.969op/s 255589393.693op/s ± 125557.226op/s 255719313.211op/s 255930378.332op/s 256027984.140op/s 256811712.221op/s 0.48% 0.627 4.393 0.09% 15425.037op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.908µs 66.379µs ± 0.272µs 66.309µs ± 0.107µs 66.463µs 66.944µs 67.214µs 67.827µs 2.29% 1.763 4.672 0.41% 0.019µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14743463.251op/s 15065226.660op/s ± 61390.285op/s 15080969.340op/s ± 24340.122op/s 15101869.235op/s 15134501.040op/s 15161437.255op/s 15172724.385op/s 0.61% -1.720 4.428 0.41% 4340.949op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 59.512µs 59.699µs ± 0.074µs 59.698µs ± 0.051µs 59.752µs 59.816µs 59.856µs 60.000µs 0.51% 0.219 0.610 0.12% 0.005µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16666590.609op/s 16750792.571op/s ± 20779.242op/s 16751053.422op/s ± 14350.021op/s 16764127.291op/s 16784188.375op/s 16794606.512op/s 16803266.555op/s 0.31% -0.209 0.591 0.12% 1469.314op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.912µs ± 0.003µs 3.913µs ± 0.002µs 3.914µs 3.917µs 3.918µs 3.932µs 0.50% 0.161 6.639 0.09% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254306476.799op/s 255599204.437op/s ± 227538.441op/s 255573107.953op/s ± 141160.906op/s 255741673.123op/s 255945032.818op/s 256063934.201op/s 256731160.707op/s 0.45% -0.138 6.593 0.09% 16089.397op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 56.206µs 56.626µs ± 0.184µs 56.618µs ± 0.124µs 56.744µs 56.919µs 56.982µs 57.019µs 0.71% 0.037 -0.699 0.32% 0.013µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17538110.959op/s 17659880.161op/s ± 57421.509op/s 17662304.256op/s ± 38706.074op/s 17698288.141op/s 17758737.736op/s 17785261.924op/s 17791585.746op/s 0.73% -0.024 -0.696 0.32% 4060.314op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.732µs 51.815µs ± 0.036µs 51.816µs ± 0.020µs 51.833µs 51.872µs 51.907µs 51.984µs 0.32% 0.599 1.878 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19236816.676op/s 19299254.957op/s ± 13271.301op/s 19299027.330op/s ± 7496.312op/s 19307562.290op/s 19318845.927op/s 19323670.503op/s 19330371.880op/s 0.16% -0.592 1.852 0.07% 938.423op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.026µs 6.037µs ± 0.009µs 6.036µs ± 0.003µs 6.039µs 6.050µs 6.077µs 6.081µs 0.76% 2.967 10.006 0.15% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 164434929.196op/s 165641730.473op/s ± 253537.311op/s 165676791.193op/s ± 82619.176op/s 165765160.143op/s 165891018.467op/s 165928551.807op/s 165948907.578op/s 0.16% -2.952 9.931 0.15% 17927.795op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255617171.099op/s; 255669857.411op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [77.444µs; 77.567µs] or [-0.079%; +0.079%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12892456.232op/s; 12912865.393op/s] or [-0.079%; +0.079%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.265µs; 71.356µs] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14014526.379op/s; 14032312.448op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255616428.875op/s; 255668451.550op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [76.954µs; 77.049µs] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/378282246310005 throughput [12979118.146op/s; 12995017.517op/s] or [-0.061%; +0.061%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [51.826µs; 51.836µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19291796.353op/s; 19295337.634op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.036µs; 6.038µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/x371413321323331 throughput [165617218.819op/s; 165662191.905op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ throughput [255558811.738op/s; 255619276.773op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [66.341µs; 66.417µs] or [-0.057%; +0.057%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15056718.557op/s; 15073734.763op/s] or [-0.056%; +0.056%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [59.688µs; 59.709µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16747912.768op/s; 16753672.374op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.913µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255567669.798op/s; 255630739.077op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [56.601µs; 56.652µs] or [-0.045%; +0.045%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17651922.092op/s; 17667838.230op/s] or [-0.045%; +0.045%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [51.811µs; 51.820µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19297415.682op/s; 19301094.231op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.036µs; 6.038µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165606592.640op/s; 165676868.306op/s] or [-0.021%; +0.021%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 405a237 1742549079 ivoanjo/bump-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 244.166ns 253.155ns ± 11.588ns 247.819ns ± 2.070ns 253.471ns 281.289ns 291.291ns 292.930ns 18.20% 1.847 2.452 4.57% 0.819ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [251.549ns; 254.761ns] or [-0.634%; +0.634%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 405a237 1742549079 ivoanjo/bump-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.970ms 5.985ms ± 0.007ms 5.985ms ± 0.003ms 5.988ms 5.995ms 6.000ms 6.051ms 1.11% 3.812 31.584 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.984ms; 5.986ms] or [-0.017%; +0.017%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 405a237 1742549079 ivoanjo/bump-dependencies
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 145.767µs 146.868µs ± 0.291µs 146.834µs ± 0.119µs 146.960µs 147.339µs 147.758µs 148.324µs 1.02% 0.966 6.488 0.20% 0.021µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [146.828µs; 146.909µs] or [-0.027%; +0.027%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.84%. Comparing base (51d4c2b) to head (405a237).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
- Coverage   72.96%   72.84%   -0.13%     
==========================================
  Files         334      334              
  Lines       50915    50923       +8     
==========================================
- Hits        37149    37093      -56     
- Misses      13766    13830      +64
Components Coverage Δ
crashtracker 42.85% <ø> (ø)
crashtracker-ffi 6.25% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.81% <ø> (-0.16%) ⬇️
data-pipeline-ffi 90.29% <ø> (ø)
ddcommon 82.95% <ø> (ø)
ddcommon-ffi 70.13% <ø> (ø)
ddtelemetry 61.87% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 89.60% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.47% <ø> (+0.06%) ⬆️
profiling 81.86% <ø> (+0.09%) ⬆️
profiling-ffi 69.90% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.85% <ø> (-1.22%) ⬇️
sidecar-ffi 0.29% <ø> (-9.56%) ⬇️
spawn-worker 54.37% <ø> (ø)
tinybytes 91.59% <ø> (ø)
trace-mini-agent 74.66% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 96.00% <ø> (ø)
trace-protobuf 78.13% <ø> (ø)
trace-utils 92.91% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ivoanjo
Copy link
Member Author

ivoanjo commented Mar 18, 2025

Hmm... the "FFI alpine-build via docker bake" is broken and I believe it's because of rust-lang/cc-rs#1407 . That should be fixed in version 1.2.17 of the cc crate, so let's wait for that release and see if it's enough.

@morrisonlevi
Copy link
Contributor

morrisonlevi commented Mar 20, 2025

@ivoanjo , it's a known issue for now, I suggest something like this:

cargo update cc --precise 1.1.31

This is the exact command I ran a few months ago. I see 1.1.37 is out, I have not verified that one, but you could try it.

@morrisonlevi morrisonlevi changed the title [NO-TICKET] Bump protobuf and ring as suggested by dependabot build: bump protobuf and ring as suggested by dependabot Mar 20, 2025
@ivoanjo
Copy link
Member Author

ivoanjo commented Mar 20, 2025

Unfortunately that doesn't work, the latest ring wants a newer cc:

$ cargo update cc --precise 1.1.31 
    Updating crates.io index
error: failed to select a version for the requirement `cc = "^1.2.8"`
candidate versions found which didn't match: 1.1.31
location searched: crates.io index
required by package `ring v0.17.14`

:(

@r1viollet
Copy link
Contributor

r1viollet commented Mar 20, 2025 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 24.56 MB 24.57 MB +.05% (+13.55 KB) 🔍
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.80 MB 7.80 MB +0% (+728 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 78.42 MB 78.46 MB +.04% (+34.17 KB) 🔍
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 7.73 MB 7.73 MB --.02% (-1.64 KB) 💪
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 72.75 MB 72.67 MB --.10% (-77.68 KB) 💪
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 23.14 MB 23.10 MB --.15% (-37.85 KB) 💪
i686-alpine-linux-musl
Artifact Baseline Commit Change
/i686-alpine-linux-musl/lib/libdatadog_profiling.a 67.70 MB 67.70 MB +0% (+614 B) 👌
/i686-alpine-linux-musl/lib/libdatadog_profiling.so 8.25 MB 8.25 MB +.04% (+4.00 KB) 🔍
/i686-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.71 MB 23.70 MB --.04% (-11.70 KB) 💪
i686-unknown-linux-gnu
Artifact Baseline Commit Change
/i686-unknown-linux-gnu/lib/libdatadog_profiling.a 68.58 MB 68.64 MB +.07% (+55.88 KB) 🔍
/i686-unknown-linux-gnu/lib/libdatadog_profiling.so 8.13 MB 8.14 MB +.01% (+1.46 KB) 🔍
/i686-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 21.33 MB 21.35 MB +.09% (+19.96 KB) 🔍
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 17.19 MB 17.36 MB +.95% (+168.50 KB) 🔍
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 55.10 KB 55.10 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 118.69 MB 119.69 MB +.84% (+1.00 MB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 713.13 MB 714.87 MB +.24% (+1.74 MB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.05 MB 5.07 MB +.41% (+21.50 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 55.10 KB 55.10 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 16.30 MB 16.39 MB +.57% (+96.00 KB) 🔍
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 26.96 MB 27.10 MB +.49% (+136.59 KB) 🔍
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 14.58 MB 14.71 MB +.87% (+131.00 KB) 🔍
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 55.94 KB 55.94 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 120.73 MB 121.70 MB +.80% (+992.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 704.68 MB 705.91 MB +.17% (+1.23 MB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.84 MB 3.85 MB +.25% (+10.00 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 55.94 KB 55.94 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.96 MB 17.02 MB +.36% (+64.00 KB) 🔍
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 24.95 MB 25.01 MB +.23% (+59.65 KB) 🔍
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 67.70 MB 67.70 MB +0% (+614 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.25 MB 8.25 MB +.04% (+4.00 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.71 MB 23.70 MB --.04% (-11.70 KB) 💪
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 68.58 MB 68.64 MB +.07% (+55.88 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.13 MB 8.14 MB +.01% (+1.46 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 21.33 MB 21.35 MB +.09% (+19.96 KB) 🔍

ivoanjo added 2 commits March 21, 2025 09:24
@ivoanjo
Upgrade cc to 1.2.17
b5a1e5a 
Let's see if these fixes the issues with building on alpine...
@ivoanjo
Merge branch 'main' into ivoanjo/bump-dependencies
405a237
@ivoanjo
Copy link
Member Author

ivoanjo commented Mar 21, 2025

The upgrade to cc 1.2.17 works! 🎉 CI is now green :)

@ivoanjo ivoanjo merged commit 381c24a into main Mar 21, 2025
35 checks passed
@ivoanjo ivoanjo deleted the ivoanjo/bump-dependencies branch March 21, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paullegranddc paullegranddc paullegranddc left review comments

@VianneyRuhlmann VianneyRuhlmann VianneyRuhlmann approved these changes

Assignees

No one assigned

Labels

ci-build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ivoanjo @codecov-commenter @morrisonlevi @r1viollet @paullegranddc @VianneyRuhlmann