build(macOS): set the LC_ID_DYLIB for mac binaries to set correct name for linking#1646
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom Mar 5, 2026
Merged
Conversation
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
BenchmarksComparisonBenchmark execution time: 2026-03-05 09:31:29 Comparing candidate commit 0aac0a4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1646 +/- ##
==========================================
+ Coverage 71.20% 71.24% +0.04%
==========================================
Files 425 425
Lines 62715 62695 -20
==========================================
+ Hits 44657 44668 +11
+ Misses 18058 18027 -31
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
gyuheon0h
approved these changes
Mar 3, 2026
hoolioh
approved these changes
Mar 4, 2026
ivoanjo
reviewed
Mar 4, 2026
Member
ivoanjo
left a comment
ivoanjo
left a comment
There was a problem hiding this comment.
This looks reasonable to me, but indeed I'm not seeing the macOS builds coming up in CI so I can confirm the value is set correctly + test them out.
Does someone know what's up there?
ekump
force-pushed
the
ekump/macos-build-path-issue
branch
from
f961c08 to
e19f479
Compare
ekump
force-pushed
the
ekump/macos-build-path-issue
branch
from
e19f479 to
cfd13f8
Compare
hoolioh
added a commit
that referenced
this pull request
Mar 5, 2026
# What does this PR do? Remove the `depth` modifier when fetchin `origin/main` in order to avoid problems finding the merge base when getting the differences between the feature branch and `main`. # Motivation Workflow failed in #1646
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-mergequeue-cf854d
bot
deleted the
ekump/macos-build-path-issue
branch
gh-worker-dd-devflow-36fce6
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
gh-worker-dd-mergequeue-cf854d bot
pushed a commit
that referenced
this pull request
Mar 5, 2026
# What does this PR do? [feat: process context publication](#1585) [ci: pass macos label to downstream project](#1647) [chore: implement otel process ctx update](#1640) [chore(crashtracking): emit a best effort stacktrace for Mac](#1645) [ci: remove depth so it can cause problems when getting the diffs](#1657) [build(macOS): set the LC_ID_DYLIB for mac binaries to set correct name for linking](#1646) [chore(ci): fix crashtracker receiver binary rpath setting](#1652) [chore(deps): bump blazesym to 0.2.3 and blazesym-c to 0.1.7](#1654) [feat: otel process ctxt protobuf encoding](#1651) [chore(crashtracker): fix benchmark job](#1664) # Motivation What inspired you to submit this pull request? # Additional Notes Anything else we should know when reviewing? # How to test the change? Describe here in detail how the change can be validated. Co-authored-by: gyuheon.oh <gyuheon.oh@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
for macOS builds we were not setting
LC_ID_DYLIB, so the absolute path at build time was being used, which causes problems when you link against the dylib on another machine.This PR should correctly set
LC_ID_DYLIBfor macOS. Something similar was done for linux in #1258The post-build fix logic has been removed since it doesn't seem to be used anywhere else anymore.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
cargo run --bin release --release -- --out /tmp/libdatadog-outputPrior to this change the output would have looked like:
With this change it now looks like: