Skip to content

[cluster-agent] Add new cws instrumentation metrics #20557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

Gui774ume
Copy link
Contributor

@Gui774ume Gui774ume commented Jun 20, 2025

What does this PR do?

This PR updates the metrics of the cluster-agent check to collect the new metrics of the cws-instrumentation webhook introduced in this PR.

Motivation

These metrics will help better track the performance of the cws-instrumentation webhook.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (5ca83b8) to head (006e06f).
Report is 17 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
datadog_cluster_agent 90.19% <ø> (ø)
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Gui774ume Gui774ume force-pushed the will/new-cws-instrumentation-metrics branch 2 times, most recently from 6ac2dfc to 9752966 Compare June 23, 2025 07:15
Copy link

⚠️ Major version bump
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@Gui774ume Gui774ume force-pushed the will/new-cws-instrumentation-metrics branch from 9752966 to 006e06f Compare June 23, 2025 07:30
@Gui774ume
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 23, 2025

View all feedbacks in Devflow UI.

2025-06-23 08:28:35 UTC ℹ️ Start processing command /merge


2025-06-23 08:28:41 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-06-23 09:33:01 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@Gui774ume Gui774ume added this pull request to the merge queue Jun 23, 2025
Merged via the queue into master with commit c793ef5 Jun 23, 2025
52 checks passed
@Gui774ume Gui774ume deleted the will/new-cws-instrumentation-metrics branch June 23, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants