gpu: fix operator deployment instructions #20552
Conversation
gpu/README.md
Outdated
| ```yaml | ||
| spec: | ||
| features: | ||
| oomKill: # Only enable this feature if there is nothing else that requires the system-probe container in all agent pods |
There was a problem hiding this comment.
| oomKill: # Only enable this feature if there is nothing else that requires the system-probe container in all agent pods | |
| oomKill: # Only enable this feature if there is nothing else that requires the system-probe container in all Agent pods |
There was a problem hiding this comment.
why do we need to enable oomkill for SP? enabling GPUM is not enough?
There was a problem hiding this comment.
The problem is that we need the operator to enable system-probe for all pods, as the DAP does not have any effect on whether it's enabled or not. So we need to enable something that enables system-probe everywhere, oomkill seemed like a good candidate.
There was a problem hiding this comment.
so why not enable gpum then? it is also a module in system-probe
There was a problem hiding this comment.
These are the instructions for the mixed environments, so we can't enable GPUM everywhere.
There was a problem hiding this comment.
discussed that on slack, resolving for now
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
gpu/README.md
Outdated
| ```yaml | ||
| spec: | ||
| features: | ||
| oomKill: # Only enable this feature if there is nothing else that requires the system-probe container in all agent pods |
There was a problem hiding this comment.
why do we need to enable oomkill for SP? enabling GPUM is not enough?
temporal-github-worker-1
bot
dismissed
janine-c’s stale review
Review from janine-c is dismissed. Related teams and files:
- documentation
- gpu/README.md
temporal-github-worker-1
bot
added
docs/review-requested
and removed
docs/approved
labels
Co-authored-by: Janine Chan <[email protected]>
Co-authored-by: Janine Chan <[email protected]>
Co-authored-by: Janine Chan <[email protected]>
| For **mixed environments**, use the [DatadogAgentProfiles feature](https://github.com/DataDog/datadog-operator/blob/main/docs/datadog_agent_profiles.md) of the operator, which allows different configurations to be deployed for different nodes. In this case, it is not necessary to modify the DatadogAgent manifest. Instead, create a profile that enables the configuration on GPU nodes only: | ||
| For **mixed environments**, use the [DatadogAgentProfiles (DAP) feature](https://github.com/DataDog/datadog-operator/blob/main/docs/datadog_agent_profiles.md) of the operator, which allows different configurations to be deployed for different nodes. Note that this feature is disabled by default, so it needs to be enabled. For more information, see [Enabling DatadogAgentProfiles](https://github.com/DataDog/datadog-operator/blob/main/docs/datadog_agent_profiles.md#enabling-datadogagentprofiles). | ||
|
|
||
| Modifying the DatadogAgent manifest is necessary to enable certain features that are not supported by the DAP yet: |
There was a problem hiding this comment.
| Modifying the DatadogAgent manifest is necessary to enable certain features that are not supported by the DAP yet: | |
| Additionally, modify the DatadogAgent manifest to enable certain features that are not supported by the DAP yet: |
☝🏻 Suggested wording to try to make these sections flow better together. Also, I noticed that we use both the phrases the DatadogAgent manifest and the DatadogAgent configuration - do they refer to the same thing? If so, it probably makes sense to use consistent terminology instead.
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
What does this PR do?
Updates the GPU deployment instructions to fix the deployment with the Datadog operator.
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged