[AI-5441] DDS: ESET Protect: Integration v1.0.0 #20349
Open
+9,289
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datadog-agent-integrations-bot
bot
added
documentation
dev/testing
dev/tooling
qa/skip-qa
savandalasaniya-crest
changed the title
jhgilbert
added
the
editorial review
torosmassa
changed the title
sarah-witt
requested changes
May 28, 2025
There was a problem hiding this comment.
Hi @savandalasaniya-crest, thanks for the PR! I left some initial comments.
| "Intended Audience :: System Administrators", | ||
| "License :: OSI Approved :: BSD License", | ||
| "Private :: Do Not Upload", | ||
| "Programming Language :: Python :: 3.11", |
There was a problem hiding this comment.
Suggested change
| "Programming Language :: Python :: 3.11", | |
| "Programming Language :: Python :: 3.12", |
this should be python 3.12- what version of ddev are you using?
| "Topic :: System :: Monitoring", | ||
| ] | ||
| dependencies = [ | ||
| "datadog-checks-base>=4.2.0", |
There was a problem hiding this comment.
Why is this so low? Most checks require "datadog-checks-base>=37.4.0"
|
|
||
| To install the ESET Protect integration, run the following Agent installation command and the following steps. For more information, see the [Integration Management][5] documentation. | ||
|
|
||
| **Note**: This step is not necessary for Agent version >= 7.65.0. |
There was a problem hiding this comment.
Suggested change
| **Note**: This step is not necessary for Agent version >= 7.65.0. | |
| **Note**: This step is not necessary for Agent version >= 7.68.0. |
temporal-github-worker-1
bot
added
agent/requested-changes
and removed
agent/review-requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a initial release PR of ESET Protect integration including all the required assets.
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged