Skip to content

[SAASINT-4023] DDS: Box: Crawler Integration v1.0.0 #20333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 28, 2025

Conversation

shubhamvekariya-crest
Copy link
Contributor

What does this PR do?

This is a initial release PR of Box integration including all the required assets.

Additional Notes

  • Crawler code for this integration has been committed in its respective repo
  • OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository.
  • Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behaviour.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@shubhamvekariya-crest shubhamvekariya-crest changed the title DDS: Box: Crawler Integration v1.0.0 [SAASINT-4023] DDS: Box: Crawler Integration v1.0.0 May 28, 2025
@drichards-87
Copy link
Contributor

Created DOCS-11048 for Docs Team review.

apiazza-dd
apiazza-dd previously approved these changes May 28, 2025
BoyangHuang
BoyangHuang previously approved these changes May 28, 2025
drichards-87
drichards-87 previously approved these changes May 28, 2025
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions and approved the PR.

Co-authored-by: DeForest Richards <[email protected]>
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed stale reviews from apiazza-dd, BoyangHuang, and drichards-87 May 28, 2025 22:01

Review from apiazza-dd is dismissed. Related teams and files:

  • saas-integrations
    • box/README.md

Review from BoyangHuang is dismissed. Related teams and files:

  • saas-integrations
    • box/README.md

Review from drichards-87 is dismissed. Related teams and files:

  • documentation
    • box/README.md
@apiazza-dd apiazza-dd enabled auto-merge May 28, 2025 22:02
@apiazza-dd apiazza-dd added this pull request to the merge queue May 28, 2025
Merged via the queue into DataDog:master with commit fc6421e May 28, 2025
46 of 48 checks passed
github-actions bot pushed a commit that referenced this pull request May 28, 2025
* Add Box crawler integration without assets

* Add Box integration with assets

* Resolve CI failure

* Resolve CI Failure

* Added dashboard screenshots

* Update dashboards and Readme

* Apply suggestions from code review

Co-authored-by: DeForest Richards <[email protected]>

---------

Co-authored-by: apiazza-dd <[email protected]>
Co-authored-by: DeForest Richards <[email protected]> fc6421e
domalessi pushed a commit that referenced this pull request May 29, 2025
* Add Box crawler integration without assets

* Add Box integration with assets

* Resolve CI failure

* Resolve CI Failure

* Added dashboard screenshots

* Update dashboards and Readme

* Apply suggestions from code review

Co-authored-by: DeForest Richards <[email protected]>

---------

Co-authored-by: apiazza-dd <[email protected]>
Co-authored-by: DeForest Richards <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants