Add allow list configuration for Consul service tags to Consul check #20306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- consul services frequently have a lot of tags that are not relevant to monitoring (routing rules, etc.) - add a configuration option `services_tags_keys_include` to the consul check to allow specification of a list of allowed tag keys to be sent to Datadog - if the allow list is empty/not set, all tags are sent (matching existing behavior)
janine-c
previously approved these changes
May 15, 2025
Clean up description phrasing Co-authored-by: Janine Chan <[email protected]>
temporal-github-worker-1
bot
dismissed
janine-c’s stale review
Review from janine-c is dismissed. Related teams and files:
- documentation
- consul/assets/configuration/spec.yaml
- consul/datadog_checks/consul/data/conf.yaml.example
temporal-github-worker-1
bot
added
docs/review-requested
and removed
docs/approved
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
services_tags_keys_includeto the consul check to allow specification of a list of allowed tag keys to be sent to Datadog, all other tags will be removed (this name is kind of awkward, I was trying to match existing options but very open to suggestions)Motivation
We have a lot of tags (50+) on some of our consul services (for traefik routing and other purposes) that are not needed in Datadog, and would like to filter them out.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged