-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update temporal integration to support temporal version 1.27 #20142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update temporal integration to support temporal version 1.27 #20142
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
f0256c1
to
6f46a92
Compare
6f46a92
to
589c384
Compare
589c384
to
b5a68d1
Compare
Hi @Kyle-Neale , sorry for the direct ping but i see you're approver of temporal integration before. Can you kindly take a look? |
Not sure why the ci is complaining about missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs team is only responsible for the metadata file, but it looks fine to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution and apologies for the delayed response.
I noticed we're dropping support for Temporal v1. Do you mind undoing those changes please? We'd like to support customers who are monitoring older versions of Temporal too.
Hi @iliakur , not sure if i'm following. |
@phuongdnguyen we want any given agent version to support both versions of Temporal. Say you're a customer who wants to upgrade your Datadog Agent, but (for whatever reason) cannot update your Temporal deployment. You'd be pissed if you're blocked from upgrading your agent, right? |
Hi @iliakur , in that case, perhaps what we might want to do is just accumulate all metrics supported through all version of Temporal. Are there any limit cause it sounds not too efficient 🤔 |
In files like Figuring out which metrics to collect efficiently is a question of implementation. Let me know if you want concrete tips for that. |
@iliakur Thanks, understood your concerns now, will make updates to the patch 👍 |
@phuongdnguyen done! left some suggestions. |
What does this PR do?
Motivation
Temporal integration is outdated. Current integration support temporal server 1.19, the latest version is 1.27. While we can include missing metrics in
extra_metrics
section, i think it's better to keep the integration up to date so users can use the agent without any more configurations.Currently, the diff between list of metrics this integration support and the latest major version of temporal is already quite large, around 70 metrics.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged