Skip to content

Conversation

aliciascott
Copy link
Contributor

@aliciascott aliciascott commented May 21, 2025

What does this PR do? What is the motivation?

Adds Windows instructions for mounting root certificates to Synthetics Private locations.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@aliciascott aliciascott requested a review from a team as a code owner May 21, 2025 21:15
@aliciascott aliciascott added the WORK IN PROGRESS No review needed, it's a wip ;) label May 21, 2025
@github-actions github-actions bot added the Images Images are added/removed with this PR label May 21, 2025
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@aliciascott aliciascott removed the WORK IN PROGRESS No review needed, it's a wip ;) label May 22, 2025
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with a few non-essential suggestions, thanks!

@aliciascott
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 22, 2025

View all feedbacks in Devflow UI.

2025-05-22 20:10:02 UTC ℹ️ Start processing command /merge


2025-05-22 20:10:10 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-05-22 20:38:12 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-05-22 20:55:04 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 45de44f into master May 22, 2025
17 of 21 checks passed
@dd-mergequeue dd-mergequeue bot deleted the aliciascott/DOCS-10975/update-PL-Windows branch May 22, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants