-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[DOCS-10927] Add preview box for human name PII detection #29471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview links (active after the
|
@@ -9,6 +9,10 @@ further_reading: | |||
text: "Best practices for creating custom scanning rules" | |||
--- | |||
|
|||
{{< callout url="https://www.datadoghq.com/product-preview/human-name-pii-detection-in-logs-using-machine-learning/" btn_hidden="false" >}} | |||
Human Name PII Detection in Logs using Machine Learning is in Preview. To enroll, click <b>Request Access</b>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Human Name PII Detection in Logs using Machine Learning is in Preview. To enroll, click <b>Request Access</b>. | |
Human Name PII Detection in Logs using machine learning is in Preview. To enroll, click <b>Request Access</b>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rtrieu, but the full name of the feature in Preview is "Human Name PII Detection in Logs using Machine Learning", which is why I left the capitalization as it is: https://www.datadoghq.com/product-preview/human-name-pii-detection-in-logs-using-machine-learning/. What do you think?
Otherwise, I think I'd go with sentence cap for the whole thing:
Human name PII detection in logs using machine learning is in Preview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi May, sorry for not leaving an explanation of my original feedback, but I was thinking ML doesn't need to be capitalized since it is a mechanism. I think going sentence cap is more in line with our style guide, but of course feel free to ignore. If you do decide to go full sentence cap, I would just suggest capitalizing Logs since it is the feature/product name:
Human name PII detection in Logs using machine learning is in Preview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll go all sentence cap. Also "logs" here is referencing just logs (like application logs) and not the Log Management product, so I'll keep it lowercase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh d'oh, ok!
@@ -9,6 +9,10 @@ further_reading: | |||
text: "Set up Sensitive Data Scanner" | |||
--- | |||
|
|||
{{< callout url="https://www.datadoghq.com/product-preview/human-name-pii-detection-in-logs-using-machine-learning/" btn_hidden="false" >}} | |||
Human Name PII Detection in Logs using Machine Learning is in Preview. To enroll, click <b>Request Access</b>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Human Name PII Detection in Logs using Machine Learning is in Preview. To enroll, click <b>Request Access</b>. | |
Human Name PII Detection in Logs using machine learning is in Preview. To enroll, click <b>Request Access</b>. |
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do? What is the motivation?
Add preview box for Human Name PII Detection
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes