Skip to content

Conversation

@maycmlee
Copy link
Contributor

@maycmlee maycmlee commented Mar 31, 2025

What does this PR do? What is the motivation?

  • Renames Google Chronicle to Google SecOps for OP docs.
  • Keeps the 3 chronicle shortcodes because if I delete them, it breaks build. I think it might be something related to translations.
  • Creates 3 google_secops shortcodes with the same content as the respective chronicle shortcode (except for name change).

For docs reviewer:
There's no need to go through all the files because it was mostly a find and replace update. Could you just check these files and the staging previews for them?

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@maycmlee maycmlee requested a review from a team as a code owner March 31, 2025 19:46
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Mar 31, 2025
@maycmlee maycmlee added WORK IN PROGRESS No review needed, it's a wip ;) and removed Architecture Everything related to the Doc backend labels Mar 31, 2025
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Renamed files

Modified Files

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Mar 31, 2025
@maycmlee maycmlee added editorial review Waiting on a more in-depth review and removed WORK IN PROGRESS No review needed, it's a wip ;) editorial review Waiting on a more in-depth review labels Apr 1, 2025
Copy link
Contributor

@urseberry urseberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the review guidance!

@@ -1 +1 @@
Enter the Google Chronicle endpoint URL. For example, `https://chronicle.googleapis.com`. No newline at end of file
Enter the Google SecOps endpoint URL. For example, `https://chronicle.googleapis.com`. No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, Google hasn't changed the endpoint URL yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing @urseberry! They haven't: https://cloud.google.com/chronicle/docs/reference/rest#service-endpoint. They also haven't updated their docs url: https://cloud.google.com/chronicle/docs) 😄

@maycmlee maycmlee requested review from a team and datamarmot as code owners January 5, 2026 16:19
@maycmlee maycmlee requested review from a team as code owners January 5, 2026 16:19
@maycmlee maycmlee closed this Jan 5, 2026
@maycmlee
Copy link
Contributor Author

maycmlee commented Jan 5, 2026

Closed in favor of: #33655

@maycmlee maycmlee deleted the may/rename-google-chronicle-to-secops branch January 5, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants