Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cross org api docs to include auth headers #28023

Closed
wants to merge 2 commits into from

Conversation

abe-lin-dd
Copy link

@abe-lin-dd abe-lin-dd commented Mar 7, 2025

What does this PR do? What is the motivation?

When writing synthetic tests for cross org, we noticed that the
documentation incorrectly stated that api and app key need to be passed in as query parameters.

The app and api key need to be passed in as request headers for the cross org api to work properly. See linked synthetic test PR for usage of these headers.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@abe-lin-dd abe-lin-dd requested a review from a team as a code owner March 7, 2025 15:58
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Preview links (active after the build_preview check completes)

Modified Files

@abe-lin-dd abe-lin-dd changed the title [WIP] Update cross org api docs to include auth headers Update cross org api docs to include auth headers Mar 7, 2025
@abe-lin-dd
Copy link
Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 7, 2025

View all feedbacks in Devflow UI.
2025-03-07 18:29:46 UTC ℹ️ Start processing command /merge


2025-03-07 18:29:53 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-03-07 18:32:06 UTC ⚠️ MergeQueue: This merge request was unqueued

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants