Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-10262, 9539 - improvements to DSM docs #27986

Merged
merged 2 commits into from
Mar 6, 2025
Merged

DOCS-10262, 9539 - improvements to DSM docs #27986

merged 2 commits into from
Mar 6, 2025
+21 −82

Conversation

cswatt
Copy link
Contributor

@cswatt cswatt commented Mar 5, 2025 •
edited
Loading

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@cswatt cswatt added the WORK IN PROGRESS No review needed, it's a wip ;) label Mar 5, 2025
@cswatt cswatt requested review from a team as code owners March 5, 2025 22:07
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Mar 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Preview links (active after the build_preview check completes)

Removed or renamed files (these should redirect)

Modified Files

@cswatt cswatt removed the WORK IN PROGRESS No review needed, it's a wip ;) label Mar 5, 2025
aliciascott
aliciascott approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

piochelepiotr
piochelepiotr reviewed Mar 6, 2025
View reviewed changes
content/en/data_streams/_index.md Outdated
| Go | All (with [manual instrumentation][1]) |
### Compatibility

Data Streams Monitoring instruments Kafka _clients_ (consumers/producers), not Kafka brokers. If you can instrument your client infrastructure, you can use Data Streams Monitoring.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put that in the installation step, not in Compatibility.
We give information about Kafka brokers from the point of view of clients. From this section, customer might think we don't give them information about Kafka brokers 🤔

@cswatt
Copy link
Contributor Author

cswatt commented Mar 6, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 6, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-03-06 17:48:18 UTC ℹ️ Start processing command /merge

2025-03-06 17:48:22 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-03-06 18:02:13 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.

2025-03-06 18:09:57 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 8147cb2 into master Mar 6, 2025
18 of 20 checks passed
@dd-mergequeue dd-mergequeue bot deleted the cecilia/docs10262-dsm-requirements branch March 6, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piochelepiotr piochelepiotr piochelepiotr approved these changes

@aliciascott aliciascott aliciascott approved these changes

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cswatt @piochelepiotr @aliciascott