Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish docs for mobile push notifications #27745

Merged
merged 5 commits into from
Mar 7, 2025

Conversation

Dalje-et
Copy link
Contributor

What does this PR do? What is the motivation?

Docs mentioned solely push notifications for incident management before, ignoring On-Call and Workflows. This PR fixes it

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@Dalje-et Dalje-et marked this pull request as ready for review February 21, 2025 09:31
@Dalje-et Dalje-et requested a review from a team as a code owner February 21, 2025 09:31
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I've left you some style edits and a question

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more clarification and then this is good to go!

@hestonhoffman
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 7, 2025

View all feedbacks in Devflow UI.
2025-03-07 16:56:46 UTC ℹ️ Start processing command /merge


2025-03-07 16:56:53 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-03-07 17:14:21 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.


2025-03-07 17:21:21 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 5374735 into master Mar 7, 2025
17 of 20 checks passed
@dd-mergequeue dd-mergequeue bot deleted the daljeet/update-mobile-app-notifications branch March 7, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants