Create doc for ec2_imdsv2_transition_payload_enabled

[louis-cqrl]

What does this PR do? What is the motivation?

Create doc for ec2_imdsv2_transition_payload_enabled (related to: DataDog/datadog-agent#33861)

Merge instructions

Merge readiness:

• Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

[github-actions]

Preview links (active after the build_preview check completes)

New or renamed files

• https://docs-staging.datadoghq.com/louis-cqrl/add-imdsv2-transition-doc/agent/faq/ec2_imdsv2_transition_payload_enabled

Modified Files

• https://docs-staging.datadoghq.com/louis-cqrl/add-imdsv2-transition-doc/agent/faq/
• https://docs-staging.datadoghq.com/louis-cqrl/add-imdsv2-transition-doc/integrations/guide/aws-integration-troubleshooting

[cswatt]

I made some edits for compliance with our docs styleguide. I also removed the "What's New" section, because this is a page about IMDSv2 enablement by default—not the new Agent version.

I hope the description of what happens to displayed hostname is clearer now. Let me know if you're ready to merge.

[sgnn7]

@louis-cqrl Left some comments. Mainly we need to refocus to the appropriate target audience for this page and add more details about the possible effects that they may notice.

[cswatt]

Just some styleguide edits. After these are resolved, this should be ready.

[cswatt]

Are we sure we want to document this publicly? I haven't really seen us talk about feature flags in the documentation before.

[sgnn7]

I may also lean that we only provide this if necessary. We want to track the hosts with instance IDs where possible.

[louis-cqrl]

done

[sgnn7]

I may also lean that we only provide this if necessary. We want to track the hosts with instance IDs where possible.

[vignesh]

@louis-cqrl thanks for sharing.

Couple minor comments:

1. Not sure I follow this sentence "Datadog ensures that displayed hostnames refer to instance IDs rather than other detected hostnames in Fleet Automation and on the Infrastructure list." Are we trying to say by in-app we will reference to instance ids or "other hostnames"
2. If possible can we also provide an example canonical hostname like how it may look?
3. Can we make sure to update this page as needed, https://docs.datadoghq.com/integrations/guide/aws-integration-troubleshooting/. We seem to heavily reference IMDSv2 in here.

[louis-cqrl]

Thx @vignesh for taking a look 🙇🏻

1. Not sure I follow this sentence "Datadog ensures that displayed hostnames refer to instance IDs rather than other detected hostnames in Fleet Automation and on the Infrastructure list." Are we trying to say by in-app we will reference to instance ids or "other hostnames"

The idea is to tell to customers is that their host will now be shown with their instance ID in the app

2. If possible can we also provide an example canonical hostname like how it may look?

I do not really know how to express it in a general way since according to various Agent and instance configurations we might fall in very various different hostname shapes (for example for aws linux instances with the hostname OS provider we can either have something as ip-11-11-11-11.ec2.internal or ip-11-11-11-11 or ip-11-11-11-11.us-west-2.compute.internal).
Moreover it might need to enter in very detailed specs that would fall under developer persona detail level that @sgnn7 wanted to avoid in this doc

Maybe adding a more detailed guide on that would more fit in docs.datadoghq.com/integrations/guide/aws-integration-troubleshooting like a section Find your canonical hostname with subsection test if your hostname is your canonical hostname? Any opinion on that ?

3. Can we make sure to update this page as needed, docs.datadoghq.com/integrations/guide/aws-integration-troubleshooting. We seem to heavily reference IMDSv2 in here.

Sure

[vignesh]

Thanks LGTM, with one minor edit to:

Let's update to mention that "Datadog ensures that displayed hostnames will refer to instance IDs rather than other detected hostnames in Fleet Automation and on the Infrastructure list." TO "Datadog ensures that displayed hostnames will refer to instance IDs"

[cswatt]

I directly committed some formatting/grammar fixes as well as Vignesh's suggestion. Approving again!