Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API Clients team to include Web Frameworks team #27367

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Update API Clients team to include Web Frameworks team #27367

merged 4 commits into from
Jan 31, 2025
+2 −2

Conversation

jack-edmonds-dd
Copy link
Contributor

Add Web Frameworks team to CODEOWNERS

@jack-edmonds-dd jack-edmonds-dd requested review from a team as code owners January 29, 2025 19:44
@github-actions github-actions bot added the Github Related to Github configurations label Jan 29, 2025
@janine-c
Copy link
Contributor

Hey @jack-edmonds-dd , I'm seeing an error when I look at the file:

make sure the team @datadog/web-frameworks exists, is publicly visible, and has write access to the repository

I can't see the Web Frameworks team when I look for it - I wonder if changing the visibility for the team might fix the issue?

@janine-c
Copy link
Contributor

Ah, there we go, I needed to give the Web Frameworks team access to the repo as well 🙂

@janine-c
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 29, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-01-29 23:45:59 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-01-29 23:49:08 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.

2025-01-29 23:51:25 UTC ⚠️ MergeQueue: This merge request build was cancelled

[email protected] cancelled this merge request build

@janine-c
Copy link
Contributor

/merge -c

@janine-c
Copy link
Contributor

Sorry webops 😅

@jack-edmonds-dd
Copy link
Contributor Author

@janine-c Thanks. Can you try to merge it again?

@janine-c
Copy link
Contributor

@jack-edmonds-dd Just need an approval from someone on the WebOps-Platform team and then we'll be good to go! Might be worth giving them a poke in #websites?

@jack-edmonds-dd
Copy link
Contributor Author

@janine-c Thanks. Can you try again now?

@janine-c
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 31, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-01-31 17:49:14 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.

2025-01-31 17:56:10 UTC ℹ️ MergeQueue: This merge request was merged

@janine-c
Copy link
Contributor

There we go, it's running now and I'll watch it to make sure it merges successfully. For future reference, once a PR has all of the required approvals, you can comment /merge to add it to the queue; it doesn't have to be a codeowner 🙂

@dd-mergequeue dd-mergequeue bot merged commit c585223 into master Jan 31, 2025
14 of 20 checks passed
@dd-mergequeue dd-mergequeue bot deleted the jack-edmonds-dd/web-frameworks-rename branch January 31, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janine-c janine-c janine-c approved these changes

@davidejones davidejones davidejones approved these changes

Assignees
No one assigned
Labels
Github Related to Github configurations mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jack-edmonds-dd @janine-c @davidejones