Skip to content

switch core to standard from rubocop #4677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 22, 2025
Merged

switch core to standard from rubocop #4677

merged 8 commits into from
May 22, 2025

Conversation

p-datadog
Copy link
Member

What does this PR do?

Switches core to use standard instead of rubocop

Motivation:
We decided to standardize on standard

Change log entry
None

Additional Notes:

How to test the change?

@p-datadog p-datadog requested a review from a team as a code owner May 21, 2025 20:17
@github-actions github-actions bot added the core Involves Datadog core libraries label May 21, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.71038% with 17 lines in your changes missing coverage. Please review.

Project coverage is 97.73%. Comparing base (7de1732) to head (fc10668).

Files with missing lines Patch % Lines
lib/datadog/core/remote/client.rb 52.38% 10 Missing ⚠️
lib/datadog/core/utils/duration.rb 86.66% 2 Missing ⚠️
lib/datadog/core/utils/time.rb 66.66% 2 Missing ⚠️
lib/datadog/core/environment/container.rb 95.00% 1 Missing ⚠️
lib/datadog/core/environment/ext.rb 50.00% 1 Missing ⚠️
lib/datadog/core/metrics/logging.rb 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4677      +/-   ##
==========================================
- Coverage   97.73%   97.73%   -0.01%     
==========================================
  Files        1455     1455              
  Lines       87359    87360       +1     
  Branches     4490     4492       +2     
==========================================
- Hits        85382    85380       -2     
- Misses       1977     1980       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: standard-core
Commit report: fc10668
Test service: dd-trace-rb

✅ 0 Failed, 21296 Passed, 1373 Skipped, 4m 6.55s Total Time

Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍🏼

@p-datadog p-datadog merged commit ba846e2 into master May 22, 2025
444 checks passed
@p-datadog p-datadog deleted the standard-core branch May 22, 2025 12:33
@github-actions github-actions bot added this to the 2.17.0 milestone May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants