-
Notifications
You must be signed in to change notification settings - Fork 392
Set spans as errored in AWS integration when AWS requests fail #4672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for updating Change log entry section 👏 Visited at: 2025-05-28 15:02:45 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 21700 Passed, 1299 Skipped, 4m 9.68s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4672 +/- ##
==========================================
- Coverage 97.64% 97.63% -0.01%
==========================================
Files 1470 1470
Lines 87685 87702 +17
Branches 4544 4546 +2
==========================================
+ Hits 85624 85632 +8
- Misses 2061 2070 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update of #936 for current master
What does this PR do?
Original description from #936:
I noticed that when calls to AWS error out (5xx), the spans show up as green and are not marked as being an error. The
http.status_code
tag was however being set correctly to the 5xx status code.In this PR, the
aws/instrumentation.rb
code sets the error on the span, if thestatus_code
is in theDatadog::Ext::HTTP::ERROR_RANGE
.Motivation:
Change log entry
Yes: mark AWS integration spans as errored when AWS requests fail
Additional Notes:
At the point where AWS integration runs we do not have any textual description of the error to add to the span. We add the HTTP code (e.g. 500) and the host to which the request is made also makes it into the span.
How to test the change?
Tests are added