Skip to content

graphql-root-span-resource #4628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented May 6, 2025

Set top level span to GraphQL query type and name.

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

@github-actions github-actions bot added core Involves Datadog core libraries integrations Involves tracing integrations tracing labels May 6, 2025
Copy link

github-actions bot commented May 6, 2025

👋 Hey @marcotc, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-05-06 22:01:00 UTC

@pr-commenter
Copy link

pr-commenter bot commented May 6, 2025

Benchmarks

Benchmark execution time: 2025-05-06 22:19:18

Comparing candidate commit 05de2ff in PR branch graphql-root-span-resource with baseline commit 1b96ec8 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:profiler - Allocations (profiling disabled)

  • 🟩 throughput [+448271.297op/s; +454575.814op/s] or [+9.652%; +9.788%]

scenario:profiler - Allocations (profiling enabled)

  • 🟩 throughput [+447905.365op/s; +457437.552op/s] or [+9.737%; +9.945%]

@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: graphql-root-span-resource
Commit report: 05de2ff
Test service: dd-trace-rb

❌ 1 Failed (0 Known Flaky), 20887 Passed, 1368 Skipped, 3m 36.8s Total Time

❌ Failed Tests (1)

  • Rails Rack span resource a custom controller span resource is applied propagates the custom controller span resource to the request span resource - rspec - Details

    Expand for error
     expected: "CustomSpanResource"
          got: "TestController#custom_span_resource"
     
     (compared using ==)
     
     Failure/Error: expect(trace.resource).to eq('CustomSpanResource')
     
       expected: "CustomSpanResource"
            got: "TestController#custom_span_resource"
     
     ...
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant