Skip to content

Sample propagate event #4597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Sample propagate event #4597

wants to merge 17 commits into from

Conversation

ZStriker19
Copy link
Contributor

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

Copy link

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-04-22 18:28:28 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Apr 22, 2025

Datadog Report

Branch report: sample_propagate_event
Commit report: 78529d2
Test service: dd-trace-rb

✅ 0 Failed, 20808 Passed, 1373 Skipped, 3m 31.84s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Apr 22, 2025

Benchmarks

Benchmark execution time: 2025-05-06 18:33:49

Comparing candidate commit 8bd00de in PR branch sample_propagate_event with baseline commit 1b96ec8 in branch master.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 27 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟥 throughput [-13577.823op/s; -13216.195op/s] or [-8.226%; -8.006%]

scenario:method instrumentation

  • 🟥 throughput [-12228.613op/s; -11346.387op/s] or [-6.924%; -6.425%]

scenario:profiler - stack collector

  • 🟥 throughput [-175.508op/s; -173.970op/s] or [-6.048%; -5.995%]

scenario:tracing - trace.to_digest

  • 🟥 throughput [-18513.395op/s; -17976.291op/s] or [-11.658%; -11.320%]

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (1b96ec8) to head (78529d2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4597      +/-   ##
==========================================
- Coverage   97.73%   97.72%   -0.02%     
==========================================
  Files        1415     1415              
  Lines       86247    86243       -4     
  Branches     4359     4358       -1     
==========================================
- Hits        84293    84278      -15     
- Misses       1954     1965      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ZStriker19 ZStriker19 marked this pull request as ready for review May 6, 2025 18:04
@ZStriker19 ZStriker19 requested a review from a team as a code owner May 6, 2025 18:04
@marcotc marcotc added the dev/internal Other internal work that does not need to be included in the changelog label May 6, 2025
Copy link
Member

@p-datadog p-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZStriker19 can you please fill out the PR template?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants