-
Notifications
You must be signed in to change notification settings - Fork 392
Added: Rails 8.0 support #4455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added: Rails 8.0 support #4455
Conversation
Thank you for updating Change log entry section 👏 Visited at: 2025-03-25 18:39:46 UTC |
spec/datadog/tracing/contrib/rails/rails_log_auto_injection_spec.rb
Outdated
Show resolved
Hide resolved
lib/datadog/tracing/contrib/active_support/cache/events/cache.rb
Outdated
Show resolved
Hide resolved
spec/datadog/tracing/contrib/rails/rails_log_auto_injection_spec.rb
Outdated
Show resolved
Hide resolved
BenchmarksBenchmark execution time: 2025-05-22 16:05:21 Comparing candidate commit 5e75c0c in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 1 unstable metrics. scenario:profiling - Allocations ()
|
spec/datadog/tracing/contrib/action_pack/action_dispatch/journey/router_spec.rb
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4455 +/- ##
==========================================
- Coverage 97.74% 97.62% -0.12%
==========================================
Files 1455 1459 +4
Lines 87371 87558 +187
Branches 4492 4537 +45
==========================================
+ Hits 85397 85481 +84
- Misses 1974 2077 +103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What does this PR do?
Adds support for all existing instrumentation for Rails 8.0.x.
The only production change is in how ActiveSupport cache keys are reported in a span (there's some special handling added for Rails 8), but other parts stay identical.
The tricky part was getting CI to run: Rails 8 really doesn't like to be restarted in-memory, like we do for all other versions of Rails. I had to resort to forking on each test run, something that is not actually supported by RSpec, so I added support for it in
spec/support/execute_in_fork.rb
.Change log entry
Yes. Add support for Rails 8.0.
Additional Notes:
It was soooo hard to get the tests to run, without making a complete and utter mess in the process.
How to test the change?
All changes have automated tests.