Fix propagation error on invalid headers #4451
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hey @marcotc, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md(possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None.(possible answers No/Nope/None) Visited at: 2025-03-03 23:25:46 UTC |
marcotc
commented
Mar 3, 2025
| @@ -80,6 +80,8 @@ def inject!(digest, data) | |||
| ) | |||
| end | |||
|
|
|||
| ::Datadog.logger.debug{"Injected distributed trace data into headers: #{data}"} if result | |||
There was a problem hiding this comment.
Add tests for these debug logs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4451 +/- ##
==========================================
- Coverage 97.71% 97.69% -0.03%
==========================================
Files 1374 1374
Lines 83716 83813 +97
Branches 4236 4250 +14
==========================================
+ Hits 81805 81879 +74
- Misses 1911 1934 +23 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation:
Change log entry
Additional Notes:
How to test the change?