-
Notifications
You must be signed in to change notification settings - Fork 468
chore(profiling): fix race condition when generating upload files seque… #15251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 248 ± 3 ms. The average import time from base is: 249 ± 2 ms. The import time difference between this PR and base is: -1.6 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
6fc403f to
a6d6203
Compare
Performance SLOsComparing candidate vlad/uploader-fix-race-condition (a6d6203) with baseline main (548d46a) 🟡 Near SLO Breach (6 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 19.283ms (SLO: <22.300ms 📉 -13.5%) vs baseline: ~same Memory: ✅ 66.043MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ exception-replay-enabledTime: ✅ 1.333ms (SLO: <1.450ms -8.1%) vs baseline: -0.5% Memory: ✅ 64.114MB (SLO: <67.000MB -4.3%) vs baseline: +5.0% ✅ iastTime: ✅ 19.270ms (SLO: <22.250ms 📉 -13.4%) vs baseline: +0.1% Memory: ✅ 66.056MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.405ms (SLO: <16.550ms -6.9%) vs baseline: +0.5% Memory: ✅ 53.732MB (SLO: <54.500MB 🟡 -1.4%) vs baseline: +4.6% ✅ resource-renamingTime: ✅ 19.305ms (SLO: <21.750ms 📉 -11.2%) vs baseline: -0.2% Memory: ✅ 65.931MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 22.861ms (SLO: <28.200ms 📉 -18.9%) vs baseline: +0.2% Memory: ✅ 67.189MB (SLO: <69.500MB -3.3%) vs baseline: +4.9% ✅ tracerTime: ✅ 19.246ms (SLO: <21.750ms 📉 -11.5%) vs baseline: ~same Memory: ✅ 65.941MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 21.171ms (SLO: <23.500ms -9.9%) vs baseline: ~same Memory: ✅ 67.717MB (SLO: <68.000MB 🟡 -0.4%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.311ms (SLO: <21.500ms 📉 -10.2%) vs baseline: +0.3% Memory: ✅ 65.988MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.686ms (SLO: <17.500ms -4.7%) vs baseline: ~same Memory: ✅ 65.774MB (SLO: <67.000MB 🟡 -1.8%) vs baseline: +4.6% ✅ tracer-nativeTime: ✅ 19.302ms (SLO: <21.750ms 📉 -11.3%) vs baseline: ~same Memory: ✅ 67.574MB (SLO: <72.500MB -6.8%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 17.295ms (SLO: <19.650ms 📉 -12.0%) vs baseline: -0.2% Memory: ✅ 65.971MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.765ms (SLO: <20.100ms -6.6%) vs baseline: +0.3% Memory: ✅ 65.883MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 18.983ms (SLO: <21.500ms 📉 -11.7%) vs baseline: +0.3% Memory: ✅ 65.815MB (SLO: <67.000MB 🟡 -1.8%) vs baseline: +4.6% ✅ tracer-no-templatesTime: ✅ 19.155ms (SLO: <22.000ms 📉 -12.9%) vs baseline: ~same Memory: ✅ 65.861MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 16.358ms (SLO: <19.850ms 📉 -17.6%) vs baseline: +0.4% Memory: ✅ 65.736MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +5.2% ✅ errortracking-enabled-userTime: ✅ 16.370ms (SLO: <19.400ms 📉 -15.6%) vs baseline: ~same Memory: ✅ 65.687MB (SLO: <66.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 16.336ms (SLO: <19.450ms 📉 -16.0%) vs baseline: +0.2% Memory: ✅ 65.563MB (SLO: <66.500MB 🟡 -1.4%) vs baseline: +4.7% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.067ms (SLO: <2.300ms 📉 -10.1%) vs baseline: +0.2% Memory: ✅ 52.610MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ errortracking-enabled-userTime: ✅ 2.067ms (SLO: <2.250ms -8.1%) vs baseline: +0.3% Memory: ✅ 52.604MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 2.078ms (SLO: <2.300ms -9.7%) vs baseline: +0.4% Memory: ✅ 52.553MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.6% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.592ms (SLO: <4.750ms -3.3%) vs baseline: -0.4% Memory: ✅ 61.964MB (SLO: <65.000MB -4.7%) vs baseline: +4.7% ✅ appsec-postTime: ✅ 6.608ms (SLO: <6.750ms -2.1%) vs baseline: -0.2% Memory: ✅ 62.161MB (SLO: <65.000MB -4.4%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.599ms (SLO: <4.750ms -3.2%) vs baseline: -0.2% Memory: ✅ 61.978MB (SLO: <65.000MB -4.6%) vs baseline: +4.7% ✅ debuggerTime: ✅ 1.854ms (SLO: <2.000ms -7.3%) vs baseline: -0.2% Memory: ✅ 45.227MB (SLO: <47.000MB -3.8%) vs baseline: +5.0% ✅ iast-getTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: +0.3% Memory: ✅ 42.158MB (SLO: <49.000MB 📉 -14.0%) vs baseline: +4.6% ✅ profilerTime: ✅ 1.915ms (SLO: <2.100ms -8.8%) vs baseline: +0.3% Memory: ✅ 46.466MB (SLO: <47.000MB 🟡 -1.1%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.376ms (SLO: <3.650ms -7.5%) vs baseline: -0.1% Memory: ✅ 52.640MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ tracerTime: ✅ 3.359ms (SLO: <3.650ms -8.0%) vs baseline: ~same Memory: ✅ 52.679MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.5% ✅ tracer-nativeTime: ✅ 3.352ms (SLO: <3.650ms -8.2%) vs baseline: -0.3% Memory: ✅ 54.010MB (SLO: <60.000MB -10.0%) vs baseline: +5.0% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 308.868ms (SLO: <320.950ms -3.8%) vs baseline: ~same Memory: ✅ 32.735MB (SLO: <34.500MB -5.1%) vs baseline: +5.0% ✅ deep-profiledTime: ✅ 328.147ms (SLO: <359.150ms -8.6%) vs baseline: -0.3% Memory: ✅ 38.305MB (SLO: <39.000MB 🟡 -1.8%) vs baseline: +6.3% ✅ mediumTime: ✅ 7.001ms (SLO: <7.400ms -5.4%) vs baseline: ~same Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%) vs baseline: +5.0% ✅ shallowTime: ✅ 0.939ms (SLO: <1.050ms 📉 -10.6%) vs baseline: ~same Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.5% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.992µs (SLO: <20.000µs 📉 -85.0%) vs baseline: -1.3% Memory: ✅ 31.595MB (SLO: <34.000MB -7.1%) vs baseline: +5.1% ✅ 1-count-metrics-100-timesTime: ✅ 204.102µs (SLO: <220.000µs -7.2%) vs baseline: -1.0% Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.605µs (SLO: <20.000µs 📉 -82.0%) vs baseline: +5.7% Memory: ✅ 31.575MB (SLO: <34.000MB -7.1%) vs baseline: +5.1% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.197µs (SLO: <220.000µs 🟡 -1.3%) vs baseline: -0.7% Memory: ✅ 31.575MB (SLO: <34.000MB -7.1%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.252µs (SLO: <20.000µs 📉 -88.7%) vs baseline: +0.2% Memory: ✅ 31.615MB (SLO: <34.000MB -7.0%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 138.763µs (SLO: <150.000µs -7.5%) vs baseline: +0.1% Memory: ✅ 31.575MB (SLO: <34.000MB -7.1%) vs baseline: +5.1% ✅ 1-rate-metric-1-timesTime: ✅ 3.212µs (SLO: <20.000µs 📉 -83.9%) vs baseline: +1.2% Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +4.6% ✅ 1-rate-metrics-100-timesTime: ✅ 215.320µs (SLO: <250.000µs 📉 -13.9%) vs baseline: -1.6% Memory: ✅ 31.556MB (SLO: <34.000MB -7.2%) vs baseline: +5.1% ✅ 100-count-metrics-100-timesTime: ✅ 20.491ms (SLO: <22.000ms -6.9%) vs baseline: -0.8% Memory: ✅ 31.575MB (SLO: <34.000MB -7.1%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.290ms (SLO: <2.300ms 🟡 -0.4%) vs baseline: +0.2% Memory: ✅ 31.575MB (SLO: <34.000MB -7.1%) vs baseline: +5.1% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.431ms (SLO: <1.550ms -7.7%) vs baseline: +0.7% Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.230ms (SLO: <2.550ms 📉 -12.5%) vs baseline: -0.5% Memory: ✅ 31.595MB (SLO: <34.000MB -7.1%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.529µs (SLO: <20.000µs 📉 -77.4%) vs baseline: +0.5% Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 174.985µs (SLO: <250.000µs 📉 -30.0%) vs baseline: +0.7% Memory: ✅ 31.988MB (SLO: <34.000MB -5.9%) vs baseline: +5.1% ✅ flush-1000-metricsTime: ✅ 2.134ms (SLO: <2.500ms 📉 -14.6%) vs baseline: +0.9% Memory: ✅ 32.676MB (SLO: <34.500MB -5.3%) vs baseline: +4.8%
|
…ncing
Description
Testing
Risks
Additional Notes