-
Notifications
You must be signed in to change notification settings - Fork 468
chore(profiling): improve typing in tests #15249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(profiling): improve typing in tests #15249
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 236 ± 4 ms. The average import time from base is: 237 ± 4 ms. The import time difference between this PR and base is: -0.3 ± 0.2 ms. The difference is not statistically significant (z = -1.61). Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate kowalski/chore-profiling-improve-typing-in-tests (af6bc8a) with baseline main (10e34b3) ❌ Test Failures (1 suite)❌ otelspan - 21/22✅ add-eventTime: ✅ 38.657ms (SLO: <47.150ms 📉 -18.0%) vs baseline: -0.2% Memory: ✅ 36.396MB (SLO: <47.000MB 📉 -22.6%) vs baseline: +4.7% ✅ add-metricsTime: ✅ 260.299ms (SLO: <344.800ms 📉 -24.5%) vs baseline: +0.7% Memory: ✅ 40.718MB (SLO: <47.500MB 📉 -14.3%) vs baseline: +4.6% ❌ add-tagsTime: ❌ 316.293ms (SLO: <314.000ms +0.7%) vs baseline: +0.5% Memory: ✅ 40.678MB (SLO: <47.500MB 📉 -14.4%) vs baseline: +4.8% ✅ get-contextTime: ✅ 78.803ms (SLO: <92.350ms 📉 -14.7%) vs baseline: +0.2% Memory: ✅ 36.726MB (SLO: <46.500MB 📉 -21.0%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 37.087ms (SLO: <44.500ms 📉 -16.7%) vs baseline: +3.1% Memory: ✅ 36.221MB (SLO: <47.500MB 📉 -23.7%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 56.632ms (SLO: <67.650ms 📉 -16.3%) vs baseline: -0.4% Memory: ✅ 36.774MB (SLO: <47.000MB 📉 -21.8%) vs baseline: +4.5% ✅ set-statusTime: ✅ 43.600ms (SLO: <50.400ms 📉 -13.5%) vs baseline: +2.1% Memory: ✅ 36.228MB (SLO: <47.000MB 📉 -22.9%) vs baseline: +4.7% ✅ startTime: ✅ 36.480ms (SLO: <43.450ms 📉 -16.0%) vs baseline: +3.1% Memory: ✅ 36.257MB (SLO: <47.000MB 📉 -22.9%) vs baseline: +4.8% ✅ start-finishTime: ✅ 81.619ms (SLO: <88.000ms -7.3%) vs baseline: ~same Memory: ✅ 34.033MB (SLO: <46.500MB 📉 -26.8%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 83.543ms (SLO: <89.000ms -6.1%) vs baseline: +0.1% Memory: ✅ 34.033MB (SLO: <46.500MB 📉 -26.8%) vs baseline: +4.9% ✅ update-nameTime: ✅ 36.995ms (SLO: <45.150ms 📉 -18.1%) vs baseline: ~same Memory: ✅ 36.281MB (SLO: <47.000MB 📉 -22.8%) vs baseline: +4.5% 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.958µs (SLO: <10.000µs 📉 -50.4%) vs baseline: 📈 +17.9% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ ospathbasename_noaspectTime: ✅ 1.084µs (SLO: <10.000µs 📉 -89.2%) vs baseline: +0.4% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 6.499µs (SLO: <10.000µs 📉 -35.0%) vs baseline: +6.2% Memory: ✅ 37.100MB (SLO: <39.000MB -4.9%) vs baseline: +4.7% ✅ ospathjoin_noaspectTime: ✅ 2.289µs (SLO: <10.000µs 📉 -77.1%) vs baseline: ~same Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.515µs (SLO: <10.000µs 📉 -64.9%) vs baseline: +2.7% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.8% ✅ ospathnormcase_noaspectTime: ✅ 0.563µs (SLO: <10.000µs 📉 -94.4%) vs baseline: -1.3% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.2% ✅ ospathsplit_aspectTime: ✅ 5.501µs (SLO: <10.000µs 📉 -45.0%) vs baseline: 📈 +16.1% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 1.598µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.6% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.6% ✅ ospathsplitdrive_aspectTime: ✅ 4.108µs (SLO: <10.000µs 📉 -58.9%) vs baseline: 📈 +13.4% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ ospathsplitdrive_noaspectTime: ✅ 0.693µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -0.7% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +5.1% ✅ ospathsplitext_aspectTime: ✅ 4.463µs (SLO: <10.000µs 📉 -55.4%) vs baseline: -0.2% Memory: ✅ 37.159MB (SLO: <39.000MB -4.7%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 1.379µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -0.4% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% 🟡 Near SLO Breach (6 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 19.255ms (SLO: <22.300ms 📉 -13.7%) vs baseline: -0.5% Memory: ✅ 65.935MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.340ms (SLO: <1.450ms -7.6%) vs baseline: +0.7% Memory: ✅ 64.134MB (SLO: <67.000MB -4.3%) vs baseline: +5.1% ✅ iastTime: ✅ 19.261ms (SLO: <22.250ms 📉 -13.4%) vs baseline: +0.2% Memory: ✅ 65.907MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ profilerTime: ✅ 15.321ms (SLO: <16.550ms -7.4%) vs baseline: -0.3% Memory: ✅ 53.812MB (SLO: <54.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 19.234ms (SLO: <21.750ms 📉 -11.6%) vs baseline: -0.8% Memory: ✅ 65.895MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 22.796ms (SLO: <28.200ms 📉 -19.2%) vs baseline: -0.1% Memory: ✅ 67.098MB (SLO: <69.500MB -3.5%) vs baseline: +4.8% ✅ tracerTime: ✅ 19.251ms (SLO: <21.750ms 📉 -11.5%) vs baseline: ~same Memory: ✅ 65.901MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.6% ✅ tracer-and-profilerTime: ✅ 21.187ms (SLO: <23.500ms -9.8%) vs baseline: +0.4% Memory: ✅ 67.795MB (SLO: <68.000MB 🟡 -0.3%) vs baseline: +5.0% ✅ tracer-dont-create-db-spansTime: ✅ 19.310ms (SLO: <21.500ms 📉 -10.2%) vs baseline: ~same Memory: ✅ 65.920MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.642ms (SLO: <17.500ms -4.9%) vs baseline: -0.3% Memory: ✅ 65.848MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 19.218ms (SLO: <21.750ms 📉 -11.6%) vs baseline: ~same Memory: ✅ 67.551MB (SLO: <72.500MB -6.8%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 17.307ms (SLO: <19.650ms 📉 -11.9%) vs baseline: +0.2% Memory: ✅ 66.048MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.748ms (SLO: <20.100ms -6.7%) vs baseline: ~same Memory: ✅ 65.907MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 18.928ms (SLO: <21.500ms 📉 -12.0%) vs baseline: -0.6% Memory: ✅ 65.864MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ tracer-no-templatesTime: ✅ 19.111ms (SLO: <22.000ms 📉 -13.1%) vs baseline: +0.2% Memory: ✅ 65.874MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 16.424ms (SLO: <19.850ms 📉 -17.3%) vs baseline: +0.5% Memory: ✅ 65.696MB (SLO: <66.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 16.657ms (SLO: <19.400ms 📉 -14.1%) vs baseline: +1.9% Memory: ✅ 65.706MB (SLO: <66.500MB 🟡 -1.2%) vs baseline: +5.1% ✅ tracer-enabledTime: ✅ 16.426ms (SLO: <19.450ms 📉 -15.5%) vs baseline: +0.6% Memory: ✅ 65.670MB (SLO: <66.500MB 🟡 -1.2%) vs baseline: +4.8% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.081ms (SLO: <2.300ms -9.5%) vs baseline: +1.0% Memory: ✅ 52.667MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ errortracking-enabled-userTime: ✅ 2.079ms (SLO: <2.250ms -7.6%) vs baseline: +0.2% Memory: ✅ 52.546MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ tracer-enabledTime: ✅ 2.063ms (SLO: <2.300ms 📉 -10.3%) vs baseline: ~same Memory: ✅ 52.612MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +5.2% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.592ms (SLO: <4.750ms -3.3%) vs baseline: -0.5% Memory: ✅ 62.116MB (SLO: <65.000MB -4.4%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.616ms (SLO: <6.750ms 🟡 -2.0%) vs baseline: -0.3% Memory: ✅ 62.193MB (SLO: <65.000MB -4.3%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.584ms (SLO: <4.750ms -3.5%) vs baseline: -0.2% Memory: ✅ 62.042MB (SLO: <65.000MB -4.6%) vs baseline: +5.0% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.1%) vs baseline: ~same Memory: ✅ 45.073MB (SLO: <47.000MB -4.1%) vs baseline: +4.6% ✅ iast-getTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: -0.3% Memory: ✅ 42.139MB (SLO: <49.000MB 📉 -14.0%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.911ms (SLO: <2.100ms -9.0%) vs baseline: -0.2% Memory: ✅ 46.451MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.4% ✅ resource-renamingTime: ✅ 3.372ms (SLO: <3.650ms -7.6%) vs baseline: -0.6% Memory: ✅ 52.628MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +4.7% ✅ tracerTime: ✅ 3.355ms (SLO: <3.650ms -8.1%) vs baseline: -0.5% Memory: ✅ 52.703MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.4% ✅ tracer-nativeTime: ✅ 3.365ms (SLO: <3.650ms -7.8%) vs baseline: ~same Memory: ✅ 54.014MB (SLO: <60.000MB -10.0%) vs baseline: +4.9% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 309.397ms (SLO: <320.950ms -3.6%) vs baseline: ~same Memory: ✅ 32.716MB (SLO: <34.500MB -5.2%) vs baseline: +4.9% ✅ deep-profiledTime: ✅ 329.173ms (SLO: <359.150ms -8.3%) vs baseline: -0.2% Memory: ✅ 38.270MB (SLO: <39.000MB 🟡 -1.9%) vs baseline: +5.6% ✅ mediumTime: ✅ 7.013ms (SLO: <7.400ms -5.2%) vs baseline: ~same Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.7% ✅ shallowTime: ✅ 0.951ms (SLO: <1.050ms -9.4%) vs baseline: +0.8% Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%) vs baseline: +5.1% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.010µs (SLO: <20.000µs 📉 -85.0%) vs baseline: -0.2% Memory: ✅ 31.575MB (SLO: <34.000MB -7.1%) vs baseline: +5.1% ✅ 1-count-metrics-100-timesTime: ✅ 205.646µs (SLO: <220.000µs -6.5%) vs baseline: +1.5% Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +4.6% ✅ 1-distribution-metric-1-timesTime: ✅ 3.486µs (SLO: <20.000µs 📉 -82.6%) vs baseline: +3.6% Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%) vs baseline: +4.8% ✅ 1-distribution-metrics-100-timesTime: ✅ 219.083µs (SLO: <220.000µs 🟡 -0.4%) vs baseline: +1.4% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.6% ✅ 1-gauge-metric-1-timesTime: ✅ 2.235µs (SLO: <20.000µs 📉 -88.8%) vs baseline: -0.8% Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +4.7% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.707µs (SLO: <150.000µs -8.2%) vs baseline: +0.6% Memory: ✅ 31.556MB (SLO: <34.000MB -7.2%) vs baseline: +5.1% ✅ 1-rate-metric-1-timesTime: ✅ 3.192µs (SLO: <20.000µs 📉 -84.0%) vs baseline: +0.8% Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 216.995µs (SLO: <250.000µs 📉 -13.2%) vs baseline: +1.5% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.381ms (SLO: <22.000ms -7.4%) vs baseline: ~same Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.224ms (SLO: <2.300ms -3.3%) vs baseline: -0.6% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.405ms (SLO: <1.550ms -9.4%) vs baseline: +0.2% Memory: ✅ 31.575MB (SLO: <34.000MB -7.1%) vs baseline: +5.0% ✅ 100-rate-metrics-100-timesTime: ✅ 2.217ms (SLO: <2.550ms 📉 -13.1%) vs baseline: +0.2% Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.573µs (SLO: <20.000µs 📉 -77.1%) vs baseline: +0.7% Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +3.8% ✅ flush-100-metricsTime: ✅ 174.226µs (SLO: <250.000µs 📉 -30.3%) vs baseline: -0.7% Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.133ms (SLO: <2.500ms 📉 -14.7%) vs baseline: -0.2% Memory: ✅ 32.696MB (SLO: <34.500MB -5.2%) vs baseline: +4.7%
|
Description
Testing
Risks
Additional Notes