-
Notifications
You must be signed in to change notification settings - Fork 468
chore: use static versions instead of setuptools-scm #15245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 243 ± 5 ms. The average import time from base is: 263 ± 6 ms. The import time difference between this PR and base is: -20.2 ± 0.3 ms. Import time breakdownThe following import paths have disappeared:
|
BenchmarksBenchmark execution time: 2025-11-13 19:45:45 Comparing candidate commit 9ef9050 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 365 metrics, 3 unstable metrics. |
Performance SLOsComparing candidate brettlangdon/static.versions (8464924) with baseline main (5203dda) 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 19.214ms (SLO: <22.300ms 📉 -13.8%) vs baseline: -0.4% Memory: ✅ 65.977MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.337ms (SLO: <1.450ms -7.8%) vs baseline: -0.8% Memory: ✅ 63.917MB (SLO: <67.000MB -4.6%) vs baseline: +4.5% ✅ iastTime: ✅ 19.261ms (SLO: <22.250ms 📉 -13.4%) vs baseline: -0.2% Memory: ✅ 65.953MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.537ms (SLO: <16.550ms -6.1%) vs baseline: +1.1% Memory: ✅ 53.696MB (SLO: <54.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 19.302ms (SLO: <21.750ms 📉 -11.3%) vs baseline: ~same Memory: ✅ 65.914MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ span-code-originTime: ✅ 22.838ms (SLO: <28.200ms 📉 -19.0%) vs baseline: ~same Memory: ✅ 67.269MB (SLO: <69.500MB -3.2%) vs baseline: +5.0% ✅ tracerTime: ✅ 19.247ms (SLO: <21.750ms 📉 -11.5%) vs baseline: -0.4% Memory: ✅ 66.008MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 21.238ms (SLO: <23.500ms -9.6%) vs baseline: +0.3% Memory: ✅ 67.422MB (SLO: <68.000MB 🟡 -0.9%) vs baseline: +4.6% ✅ tracer-dont-create-db-spansTime: ✅ 19.289ms (SLO: <21.500ms 📉 -10.3%) vs baseline: +0.2% Memory: ✅ 65.911MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.698ms (SLO: <17.500ms -4.6%) vs baseline: +0.5% Memory: ✅ 65.981MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 19.310ms (SLO: <21.750ms 📉 -11.2%) vs baseline: +0.2% Memory: ✅ 67.456MB (SLO: <72.500MB -7.0%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 17.316ms (SLO: <19.650ms 📉 -11.9%) vs baseline: ~same Memory: ✅ 65.900MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ tracer-no-databasesTime: ✅ 18.806ms (SLO: <20.100ms -6.4%) vs baseline: ~same Memory: ✅ 65.963MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 18.972ms (SLO: <21.500ms 📉 -11.8%) vs baseline: -0.3% Memory: ✅ 65.934MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 19.087ms (SLO: <22.000ms 📉 -13.2%) vs baseline: -0.2% Memory: ✅ 65.923MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 16.317ms (SLO: <19.850ms 📉 -17.8%) vs baseline: +0.3% Memory: ✅ 65.725MB (SLO: <66.500MB 🟡 -1.2%) vs baseline: +5.1% ✅ errortracking-enabled-userTime: ✅ 16.351ms (SLO: <19.400ms 📉 -15.7%) vs baseline: +0.2% Memory: ✅ 65.765MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +5.3% ✅ tracer-enabledTime: ✅ 16.311ms (SLO: <19.450ms 📉 -16.1%) vs baseline: -0.4% Memory: ✅ 65.551MB (SLO: <66.500MB 🟡 -1.4%) vs baseline: +4.6% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.061ms (SLO: <2.300ms 📉 -10.4%) vs baseline: ~same Memory: ✅ 52.591MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 2.068ms (SLO: <2.250ms -8.1%) vs baseline: ~same Memory: ✅ 52.570MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +5.3% ✅ tracer-enabledTime: ✅ 2.070ms (SLO: <2.300ms 📉 -10.0%) vs baseline: +0.2% Memory: ✅ 52.632MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +5.3% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.595ms (SLO: <4.750ms -3.3%) vs baseline: -0.5% Memory: ✅ 61.844MB (SLO: <65.000MB -4.9%) vs baseline: +4.6% ✅ appsec-postTime: ✅ 6.621ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: -0.4% Memory: ✅ 62.102MB (SLO: <65.000MB -4.5%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.596ms (SLO: <4.750ms -3.2%) vs baseline: -0.1% Memory: ✅ 61.900MB (SLO: <65.000MB -4.8%) vs baseline: +4.7% ✅ debuggerTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: +0.2% Memory: ✅ 45.144MB (SLO: <47.000MB -3.9%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.857ms (SLO: <2.000ms -7.1%) vs baseline: -0.3% Memory: ✅ 42.014MB (SLO: <49.000MB 📉 -14.3%) vs baseline: +5.6% ✅ profilerTime: ✅ 1.911ms (SLO: <2.100ms -9.0%) vs baseline: -0.6% Memory: ✅ 46.306MB (SLO: <47.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.371ms (SLO: <3.650ms -7.7%) vs baseline: -0.3% Memory: ✅ 52.598MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ tracerTime: ✅ 3.371ms (SLO: <3.650ms -7.6%) vs baseline: +0.2% Memory: ✅ 52.400MB (SLO: <53.500MB -2.1%) vs baseline: +5.1% ✅ tracer-nativeTime: ✅ 3.361ms (SLO: <3.650ms -7.9%) vs baseline: -0.2% Memory: ✅ 53.970MB (SLO: <60.000MB 📉 -10.1%) vs baseline: +4.9% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.172µs (SLO: <20.000µs 📉 -84.1%) vs baseline: +7.2% Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 201.975µs (SLO: <220.000µs -8.2%) vs baseline: +0.2% Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.419µs (SLO: <20.000µs 📉 -82.9%) vs baseline: +3.6% Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +4.8% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.910µs (SLO: <220.000µs 🟡 -1.4%) vs baseline: +0.7% Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.243µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +1.6% Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.701µs (SLO: <150.000µs -8.9%) vs baseline: -0.3% Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.117µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +0.9% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 216.563µs (SLO: <250.000µs 📉 -13.4%) vs baseline: -0.8% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +5.1% ✅ 100-count-metrics-100-timesTime: ✅ 20.086ms (SLO: <22.000ms -8.7%) vs baseline: +0.4% Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.220ms (SLO: <2.300ms -3.5%) vs baseline: -1.3% Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +3.4% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.407ms (SLO: <1.550ms -9.2%) vs baseline: +0.7% Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.197ms (SLO: <2.550ms 📉 -13.9%) vs baseline: +0.5% Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.591µs (SLO: <20.000µs 📉 -77.0%) vs baseline: +1.2% Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +3.5% ✅ flush-100-metricsTime: ✅ 174.457µs (SLO: <250.000µs 📉 -30.2%) vs baseline: -0.2% Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.118ms (SLO: <2.500ms 📉 -15.3%) vs baseline: +0.2% Memory: ✅ 32.657MB (SLO: <34.500MB -5.3%) vs baseline: +4.7%
|
Description
Remove
setuptools-scmand rely on statically defined versions inpyproject.tomlandddtrace/version.py.A lot of the changes are moving components away from using
ddtrace.version.get_version()to compute the version vs using the statically definedddtrace.__version__/ddtrace.version.__version__Testing
Risks
Additional Notes