feat(ffe): integrate datadog-ffe #15241
Conversation
Checking the IAST CI, it is working but some tests looks flaky: ``` FLAKY tests/appsec/iast/taint_tracking/test_native_taint_range.py::test_context_race_conditions_threads[py3.10] FLAKY tests/appsec/iast/test_overhead_control_engine.py::test_oce_max_vulnerabilities_per_request[py3.10] FLAKY tests/appsec/iast/test_overhead_control_engine.py::test_oce_reset_vulnerabilities_report[py3.10] FLAKY tests/appsec/iast/test_telemetry.py::test_log_metric[py3.10] FLAKY tests/appsec/iast/test_telemetry.py::test_log_metric_debug_deduplication[py3.10] FLAKY tests/appsec/iast/test_telemetry.py::test_log_metric_debug_deduplication_different_messages[py3.10] ```
## Description <!-- Provide an overview of the change and motivation for the change --> Bump libdatadog to v24.0.0 ## Testing <!-- Describe your testing strategy or note what tests are included --> Checked that native module compiles. ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> --------- Co-authored-by: Alberto Vara <[email protected]> Co-authored-by: Gyuheon Oh <[email protected]>
avara1986
added
the
changelog/no-changelog
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 244 ± 3 ms. The average import time from base is: 251 ± 4 ms. The import time difference between this PR and base is: -6.5 ± 0.2 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate datadog-ffe (cf7097c) with baseline main (5203dda) 📈 Performance Regressions (1 suite)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.403µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.3% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ add_inplace_aspectTime: ✅ 0.410µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.7% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.1% ✅ add_inplace_noaspectTime: ✅ 0.321µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.9% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +5.0% ✅ add_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.5% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.3% ✅ bytearray_aspectTime: ✅ 1.407µs (SLO: <10.000µs 📉 -85.9%) vs baseline: +8.0% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ bytearray_extend_aspectTime: ✅ 1.478µs (SLO: <10.000µs 📉 -85.2%) vs baseline: -1.9% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.2% ✅ bytearray_extend_noaspectTime: ✅ 0.617µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +0.5% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 0.484µs (SLO: <10.000µs 📉 -95.2%) vs baseline: +0.8% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.5% ✅ bytes_aspectTime: ✅ 1.463µs (SLO: <10.000µs 📉 -85.4%) vs baseline: 📈 +15.9% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +5.3% ✅ bytes_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.0% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +5.1% ✅ bytesio_aspectTime: ✅ 1.310µs (SLO: <10.000µs 📉 -86.9%) vs baseline: -0.2% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.9% ✅ bytesio_noaspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.5% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.2% ✅ capitalize_aspectTime: ✅ 0.734µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -1.2% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +5.0% ✅ capitalize_noaspectTime: ✅ 0.436µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +0.2% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% ✅ casefold_aspectTime: ✅ 0.731µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.8% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.2% ✅ casefold_noaspectTime: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.8% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.4% ✅ decode_aspectTime: ✅ 0.723µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.2% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.2% ✅ decode_noaspectTime: ✅ 0.420µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.6% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.2% ✅ encode_aspectTime: ✅ 0.712µs (SLO: <10.000µs 📉 -92.9%) vs baseline: ~same Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.1% ✅ encode_noaspectTime: ✅ 0.400µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.3% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +5.1% ✅ format_aspectTime: ✅ 3.366µs (SLO: <10.000µs 📉 -66.3%) vs baseline: +1.7% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.2% ✅ format_map_aspectTime: ✅ 4.119µs (SLO: <10.000µs 📉 -58.8%) vs baseline: 📈 +19.3% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.2% ✅ format_map_noaspectTime: ✅ 0.778µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +0.4% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ format_noaspectTime: ✅ 0.602µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.5% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 0.358µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.6% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.1% ✅ index_noaspectTime: ✅ 0.275µs (SLO: <10.000µs 📉 -97.3%) vs baseline: -1.7% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.2% ✅ join_aspectTime: ✅ 1.394µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +2.4% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +5.3% ✅ join_noaspectTime: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.1% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.1% ✅ ljust_aspectTime: ✅ 2.608µs (SLO: <20.000µs 📉 -87.0%) vs baseline: +4.4% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 0.403µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.2% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +5.1% ✅ lower_aspectTime: ✅ 2.193µs (SLO: <10.000µs 📉 -78.1%) vs baseline: +0.6% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.4% ✅ lower_noaspectTime: ✅ 0.365µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -0.3% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.4% ✅ lstrip_aspectTime: ✅ 2.576µs (SLO: <20.000µs 📉 -87.1%) vs baseline: 📈 +16.4% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ lstrip_noaspectTime: ✅ 0.386µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.9% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.2% ✅ modulo_aspectTime: ✅ 1.001µs (SLO: <10.000µs 📉 -90.0%) vs baseline: -1.1% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.3% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.586µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +3.7% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.999µs (SLO: <10.000µs 📉 -90.0%) vs baseline: +2.0% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +4.8% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.234µs (SLO: <10.000µs 📉 -87.7%) vs baseline: +2.8% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.2% ✅ modulo_noaspectTime: ✅ 0.627µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.4% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +5.1% ✅ replace_aspectTime: ✅ 5.326µs (SLO: <10.000µs 📉 -46.7%) vs baseline: +9.6% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.1% ✅ replace_noaspectTime: ✅ 0.464µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.4% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.1% ✅ repr_aspectTime: ✅ 0.909µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.1% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.2% ✅ repr_noaspectTime: ✅ 0.415µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.6% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 1.896µs (SLO: <20.000µs 📉 -90.5%) vs baseline: +1.6% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.2% ✅ rstrip_noaspectTime: ✅ 0.379µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.6% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +5.2% ✅ slice_aspectTime: ✅ 0.496µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.5% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.2% ✅ slice_noaspectTime: ✅ 0.445µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +0.1% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ stringio_aspectTime: ✅ 1.523µs (SLO: <10.000µs 📉 -84.8%) vs baseline: -0.9% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.1% ✅ stringio_noaspectTime: ✅ 0.715µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +1.2% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.2% ✅ strip_aspectTime: ✅ 2.544µs (SLO: <20.000µs 📉 -87.3%) vs baseline: 📈 +16.5% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ strip_noaspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.5% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.1% ✅ swapcase_aspectTime: ✅ 2.583µs (SLO: <10.000µs 📉 -74.2%) vs baseline: +6.7% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.3% ✅ swapcase_noaspectTime: ✅ 0.539µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +1.1% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ title_aspectTime: ✅ 2.430µs (SLO: <10.000µs 📉 -75.7%) vs baseline: +5.5% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.1% ✅ title_noaspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.1% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.4% ✅ translate_aspectTime: ✅ 3.192µs (SLO: <10.000µs 📉 -68.1%) vs baseline: -0.4% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +5.4% ✅ translate_noaspectTime: ✅ 1.042µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.2% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +5.2% ✅ upper_aspectTime: ✅ 2.344µs (SLO: <10.000µs 📉 -76.6%) vs baseline: +6.7% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.1% ✅ upper_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.2% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.1% 🟡 Near SLO Breach (7 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 19.263ms (SLO: <22.300ms 📉 -13.6%) vs baseline: -0.2% Memory: ✅ 66.119MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.1% ✅ exception-replay-enabledTime: ✅ 1.341ms (SLO: <1.450ms -7.5%) vs baseline: -0.1% Memory: ✅ 64.075MB (SLO: <67.000MB -4.4%) vs baseline: +4.8% ✅ iastTime: ✅ 19.263ms (SLO: <22.250ms 📉 -13.4%) vs baseline: -0.3% Memory: ✅ 66.060MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.1% ✅ profilerTime: ✅ 15.381ms (SLO: <16.550ms -7.1%) vs baseline: -0.1% Memory: ✅ 53.933MB (SLO: <54.500MB 🟡 -1.0%) vs baseline: +5.5% ✅ resource-renamingTime: ✅ 19.337ms (SLO: <21.750ms 📉 -11.1%) vs baseline: ~same Memory: ✅ 65.824MB (SLO: <67.000MB 🟡 -1.8%) vs baseline: +4.6% ✅ span-code-originTime: ✅ 22.850ms (SLO: <28.200ms 📉 -19.0%) vs baseline: ~same Memory: ✅ 67.215MB (SLO: <69.500MB -3.3%) vs baseline: +5.0% ✅ tracerTime: ✅ 19.289ms (SLO: <21.750ms 📉 -11.3%) vs baseline: +0.2% Memory: ✅ 65.982MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 21.208ms (SLO: <23.500ms -9.8%) vs baseline: -0.2% Memory: ✅ 67.555MB (SLO: <68.000MB 🟡 -0.7%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.174ms (SLO: <21.500ms 📉 -10.8%) vs baseline: -0.9% Memory: ✅ 66.139MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.589ms (SLO: <17.500ms -5.2%) vs baseline: -0.3% Memory: ✅ 65.785MB (SLO: <67.000MB 🟡 -1.8%) vs baseline: +4.6% ✅ tracer-nativeTime: ✅ 19.259ms (SLO: <21.750ms 📉 -11.5%) vs baseline: -0.3% Memory: ✅ 67.810MB (SLO: <72.500MB -6.5%) vs baseline: +5.3% ✅ tracer-no-cachesTime: ✅ 17.308ms (SLO: <19.650ms 📉 -11.9%) vs baseline: ~same Memory: ✅ 65.785MB (SLO: <67.000MB 🟡 -1.8%) vs baseline: +4.5% ✅ tracer-no-databasesTime: ✅ 18.706ms (SLO: <20.100ms -6.9%) vs baseline: -0.4% Memory: ✅ 65.805MB (SLO: <67.000MB 🟡 -1.8%) vs baseline: +4.6% ✅ tracer-no-middlewareTime: ✅ 18.988ms (SLO: <21.500ms 📉 -11.7%) vs baseline: ~same Memory: ✅ 65.746MB (SLO: <67.000MB 🟡 -1.9%) vs baseline: +4.4% ✅ tracer-no-templatesTime: ✅ 19.065ms (SLO: <22.000ms 📉 -13.3%) vs baseline: -0.3% Memory: ✅ 66.021MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 16.338ms (SLO: <19.850ms 📉 -17.7%) vs baseline: -0.4% Memory: ✅ 65.844MB (SLO: <66.500MB 🟡 -1.0%) vs baseline: +5.4% ✅ errortracking-enabled-userTime: ✅ 16.315ms (SLO: <19.400ms 📉 -15.9%) vs baseline: -0.2% Memory: ✅ 65.844MB (SLO: <66.500MB 🟡 -1.0%) vs baseline: +5.4% ✅ tracer-enabledTime: ✅ 16.295ms (SLO: <19.450ms 📉 -16.2%) vs baseline: -0.5% Memory: ✅ 65.844MB (SLO: <66.500MB 🟡 -1.0%) vs baseline: +5.2% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.068ms (SLO: <2.300ms 📉 -10.1%) vs baseline: +0.3% Memory: ✅ 52.593MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 2.063ms (SLO: <2.250ms -8.3%) vs baseline: -0.4% Memory: ✅ 52.553MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 2.095ms (SLO: <2.300ms -8.9%) vs baseline: +1.1% Memory: ✅ 52.435MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.588ms (SLO: <4.750ms -3.4%) vs baseline: -0.6% Memory: ✅ 62.167MB (SLO: <65.000MB -4.4%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.612ms (SLO: <6.750ms -2.0%) vs baseline: ~same Memory: ✅ 62.266MB (SLO: <65.000MB -4.2%) vs baseline: +5.2% ✅ appsec-telemetryTime: ✅ 4.592ms (SLO: <4.750ms -3.3%) vs baseline: -0.3% Memory: ✅ 62.167MB (SLO: <65.000MB -4.4%) vs baseline: +5.2% ✅ debuggerTime: ✅ 1.855ms (SLO: <2.000ms -7.2%) vs baseline: -0.3% Memory: ✅ 45.298MB (SLO: <47.000MB -3.6%) vs baseline: +5.2% ✅ iast-getTime: ✅ 1.853ms (SLO: <2.000ms -7.3%) vs baseline: -0.3% Memory: ✅ 42.035MB (SLO: <49.000MB 📉 -14.2%) vs baseline: +5.6% ✅ profilerTime: ✅ 1.915ms (SLO: <2.100ms -8.8%) vs baseline: ~same Memory: ✅ 46.498MB (SLO: <47.000MB 🟡 -1.1%) vs baseline: +5.3% ✅ resource-renamingTime: ✅ 3.374ms (SLO: <3.650ms -7.6%) vs baseline: +0.2% Memory: ✅ 52.514MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ tracerTime: ✅ 3.361ms (SLO: <3.650ms -7.9%) vs baseline: -0.1% Memory: ✅ 52.337MB (SLO: <53.500MB -2.2%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.364ms (SLO: <3.650ms -7.8%) vs baseline: +0.4% Memory: ✅ 54.326MB (SLO: <60.000MB -9.5%) vs baseline: +5.7% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 38.650ms (SLO: <47.150ms 📉 -18.0%) vs baseline: +0.2% Memory: ✅ 36.577MB (SLO: <47.000MB 📉 -22.2%) vs baseline: +5.5% ✅ add-metricsTime: ✅ 259.899ms (SLO: <344.800ms 📉 -24.6%) vs baseline: -0.1% Memory: ✅ 40.816MB (SLO: <47.500MB 📉 -14.1%) vs baseline: +5.2% ✅ add-tagsTime: ✅ 318.595ms (SLO: <321.000ms 🟡 -0.7%) vs baseline: +0.4% Memory: ✅ 40.798MB (SLO: <47.500MB 📉 -14.1%) vs baseline: +5.2% ✅ get-contextTime: ✅ 78.703ms (SLO: <92.350ms 📉 -14.8%) vs baseline: +0.3% Memory: ✅ 36.886MB (SLO: <46.500MB 📉 -20.7%) vs baseline: +5.6% ✅ is-recordingTime: ✅ 36.044ms (SLO: <44.500ms 📉 -19.0%) vs baseline: +0.2% Memory: ✅ 36.440MB (SLO: <47.500MB 📉 -23.3%) vs baseline: +5.7% ✅ record-exceptionTime: ✅ 57.016ms (SLO: <67.650ms 📉 -15.7%) vs baseline: ~same Memory: ✅ 37.023MB (SLO: <47.000MB 📉 -21.2%) vs baseline: +5.4% ✅ set-statusTime: ✅ 42.528ms (SLO: <50.400ms 📉 -15.6%) vs baseline: +0.1% Memory: ✅ 36.344MB (SLO: <47.000MB 📉 -22.7%) vs baseline: +6.2% ✅ startTime: ✅ 35.689ms (SLO: <43.450ms 📉 -17.9%) vs baseline: +1.1% Memory: ✅ 36.399MB (SLO: <47.000MB 📉 -22.6%) vs baseline: +5.8% ✅ start-finishTime: ✅ 82.147ms (SLO: <88.000ms -6.7%) vs baseline: +0.7% Memory: ✅ 34.151MB (SLO: <46.500MB 📉 -26.6%) vs baseline: +5.4% ✅ start-finish-telemetryTime: ✅ 83.711ms (SLO: <89.000ms -5.9%) vs baseline: +0.3% Memory: ✅ 34.111MB (SLO: <46.500MB 📉 -26.6%) vs baseline: +5.3% ✅ update-nameTime: ✅ 36.921ms (SLO: <45.150ms 📉 -18.2%) vs baseline: +0.6% Memory: ✅ 36.522MB (SLO: <47.000MB 📉 -22.3%) vs baseline: +5.6% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 308.295ms (SLO: <320.950ms -3.9%) vs baseline: -0.4% Memory: ✅ 32.775MB (SLO: <34.500MB -5.0%) vs baseline: +5.3% ✅ deep-profiledTime: ✅ 329.405ms (SLO: <359.150ms -8.3%) vs baseline: +0.3% Memory: ✅ 38.274MB (SLO: <39.000MB 🟡 -1.9%) vs baseline: +5.3% ✅ mediumTime: ✅ 7.006ms (SLO: <7.400ms -5.3%) vs baseline: +0.5% Memory: ✅ 31.654MB (SLO: <34.000MB -6.9%) vs baseline: +5.5% ✅ shallowTime: ✅ 0.937ms (SLO: <1.050ms 📉 -10.7%) vs baseline: ~same Memory: ✅ 31.575MB (SLO: <34.000MB -7.1%) vs baseline: +5.3% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.035µs (SLO: <20.000µs 📉 -84.8%) vs baseline: +3.3% Memory: ✅ 31.693MB (SLO: <34.000MB -6.8%) vs baseline: +5.4% ✅ 1-count-metrics-100-timesTime: ✅ 200.924µs (SLO: <220.000µs -8.7%) vs baseline: +0.7% Memory: ✅ 31.693MB (SLO: <34.000MB -6.8%) vs baseline: +5.6% ✅ 1-distribution-metric-1-timesTime: ✅ 3.488µs (SLO: <20.000µs 📉 -82.6%) vs baseline: +6.1% Memory: ✅ 31.674MB (SLO: <34.000MB -6.8%) vs baseline: +5.5% ✅ 1-distribution-metrics-100-timesTime: ✅ 218.366µs (SLO: <220.000µs 🟡 -0.7%) vs baseline: +1.6% Memory: ✅ 31.870MB (SLO: <34.000MB -6.3%) vs baseline: +6.1% ✅ 1-gauge-metric-1-timesTime: ✅ 2.176µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -1.7% Memory: ✅ 31.811MB (SLO: <34.000MB -6.4%) vs baseline: +6.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.810µs (SLO: <150.000µs -8.8%) vs baseline: +0.4% Memory: ✅ 31.693MB (SLO: <34.000MB -6.8%) vs baseline: +5.4% ✅ 1-rate-metric-1-timesTime: ✅ 3.136µs (SLO: <20.000µs 📉 -84.3%) vs baseline: +1.4% Memory: ✅ 31.634MB (SLO: <34.000MB -7.0%) vs baseline: +5.3% ✅ 1-rate-metrics-100-timesTime: ✅ 214.219µs (SLO: <250.000µs 📉 -14.3%) vs baseline: +0.8% Memory: ✅ 31.772MB (SLO: <34.000MB -6.6%) vs baseline: +5.8% ✅ 100-count-metrics-100-timesTime: ✅ 20.130ms (SLO: <22.000ms -8.5%) vs baseline: +1.5% Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +6.6% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.302ms (SLO: <2.300ms ~same) vs baseline: +1.2% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.404ms (SLO: <1.550ms -9.4%) vs baseline: ~same Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +6.3% ✅ 100-rate-metrics-100-timesTime: ✅ 2.179ms (SLO: <2.550ms 📉 -14.6%) vs baseline: -0.2% Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +6.4% ✅ flush-1-metricTime: ✅ 4.605µs (SLO: <20.000µs 📉 -77.0%) vs baseline: +1.8% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +5.4% ✅ flush-100-metricsTime: ✅ 172.865µs (SLO: <250.000µs 📉 -30.9%) vs baseline: -0.3% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +5.4% ✅ flush-1000-metricsTime: ✅ 2.125ms (SLO: <2.500ms 📉 -15.0%) vs baseline: +0.8% Memory: ✅ 32.755MB (SLO: <34.500MB -5.1%) vs baseline: +5.0%
|
emmettbutler
left a comment
emmettbutler
left a comment
There was a problem hiding this comment.
This needs release note, other than that and the riotfile it doesn't look like I need to do a thorough review.
Added the release note, @emmettbutler following the approach of other products in preview, I only included the “prelude” section. |
avara1986
removed
the
changelog/no-changelog
|
force-merging because everything's passed except the last benchmarks |
#15231 to main --------- Co-authored-by: Oleksii Shmalko <[email protected]> Co-authored-by: Gyuheon Oh <[email protected]> Co-authored-by: Emmett Butler <[email protected]> (cherry picked from commit 9f69a83)
#15231 to main --------- Co-authored-by: Oleksii Shmalko <[email protected]> Co-authored-by: Gyuheon Oh <[email protected]> Co-authored-by: Emmett Butler <[email protected]> (cherry picked from commit 9f69a83)
Backport 9f69a83 from #15241 to 4.0. #15231 to main Co-authored-by: Alberto Vara <[email protected]> Co-authored-by: Oleksii Shmalko <[email protected]> Co-authored-by: Gyuheon Oh <[email protected]> Co-authored-by: Emmett Butler <[email protected]>
#15231 to main --------- Co-authored-by: Oleksii Shmalko <[email protected]> Co-authored-by: Gyuheon Oh <[email protected]> Co-authored-by: Emmett Butler <[email protected]>
#15231 to main