-
Notifications
You must be signed in to change notification settings - Fork 468
chore(di): add process_tags #15225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dubloom/process-tags-collection
Are you sure you want to change the base?
chore(di): add process_tags #15225
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 240 ± 3 ms. The average import time from base is: 240 ± 3 ms. The import time difference between this PR and base is: 0.6 ± 0.1 ms. Import time breakdownThe following import paths have grown:
|
…ags-dynamic-instrumentation
tests/debugging/test_encoding.py
Outdated
| from ddtrace.internal.process_tags.constants import ENTRYPOINT_BASEDIR_TAG | ||
| from ddtrace.internal.process_tags.constants import ENTRYPOINT_NAME_TAG | ||
| from ddtrace.internal.process_tags.constants import ENTRYPOINT_TYPE_SCRIPT | ||
| from ddtrace.internal.process_tags.constants import ENTRYPOINT_TYPE_TAG | ||
| from ddtrace.internal.process_tags.constants import ENTRYPOINT_WORKDIR_TAG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here it's enough to test that the field is set. Testing for the actual values should be done in a unit test for the process tags feature itself to avoid redundancy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in 0972b8d
This PR implements this RFC for dynamic instrumentation.
Add process_tags to dynamic instrumentation payload
Testing